[20965] Fix Python Installation version in Github CI. Address failing system tests environment issues. by Mario-DL · Pull Request #4759 · eProsima/Fast-DDS

Mario-DL · 2024-05-08T13:18:09Z

Description

This PR addresses failing github CI system tests.

It fixes Python installation version in Windows & Ubuntu Github CIs (macOs was already doing it).
Selects the appropriate python version in the launcher used in .bat tool files by means of an environment variable PYTHON_VERSION {Major.Minor}.
Prevents Qt from setting-up Python, as we are who manage the Python installation

Notes:

In windows, pywin32 is not listed as a required python package at the Python Dependencies step as it is a requirement of colcon and it is installed along with it.
Python version is not fixed in the sanitizers jobs since system tests are not run there.

Work done in #4731 precedes this PR.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A Changes are ABI compatible.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

JesusPoderoso · 2024-05-09T09:11:59Z

@richiprosima please test this

JesusPoderoso

LRGTM!
Great job @Mario-DL! 🎉

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

EduPonz · 2024-05-09T12:43:11Z

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify · 2024-05-09T12:43:17Z

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

Details

#4764 [20965] Fix Python Installation version in Github CI. Address failing system tests environment issues. (backport #4759) has been created for branch 2.13.x
#4765 [20965] Fix Python Installation version in Github CI. Address failing system tests environment issues. (backport #4759) has been created for branch 2.10.x but encountered conflicts
#4766 [20965] Fix Python Installation version in Github CI. Address failing system tests environment issues. (backport #4759) has been created for branch 2.6.x but encountered conflicts

…tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781)

…tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) # Conflicts: # test/system/tools/fastdds/CMakeLists.txt

…tests environment issues (#4759) (#4764) * Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) * Remove use of deprecated FindPythonInterp (#4447) Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

…tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) # Conflicts: # test/system/tools/fastdds/CMakeLists.txt

…tests environment issues. (#4759, #4447, #4770) (#4765) * Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) # Conflicts: # test/system/tools/fastdds/CMakeLists.txt * Solve conflicts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Remove use of deprecated FindPythonInterp (#4447) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Add missing Python3_executable communication test command Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Do not require PYTHON_VERSION to be defined in .bat files (#4770) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

…tests environment issues (#4759) (#4766) * Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) # Conflicts: # test/system/tools/fastdds/CMakeLists.txt * Solve conflicts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Remove use of deprecated FindPythonInterp (#4447) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Add missing Python3_executable communication test command Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Do not require PYTHON_VERSION to be defined in .bat files (#4770) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

Mario-DL added 2 commits May 8, 2024 14:56

Refs #20965: Install a fix python version in ubuntu and windows cis

4da12fb

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20965: Decide Python environment depending on the version

820e218

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL added this to the v2.14.2 milestone May 8, 2024

Mario-DL requested a review from richiprosima May 8, 2024 13:20

github-actions bot added the ci-pending PR which CI is running label May 8, 2024

This comment was marked as outdated.

Sign in to view

Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI

f63d0ad

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL dismissed JesusPoderoso’s stale review via f63d0ad May 9, 2024 06:41

Mario-DL requested a review from JesusPoderoso May 9, 2024 06:42

JesusPoderoso previously approved these changes May 9, 2024

View reviewed changes

Refs #20965: Add some comments

a41da1f

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels May 9, 2024

Mario-DL dismissed JesusPoderoso’s stale review via a41da1f May 9, 2024 12:28

JesusPoderoso approved these changes May 9, 2024

View reviewed changes

EduPonz merged commit 3b2e781 into master May 9, 2024

EduPonz deleted the hotfix/20965 branch May 9, 2024 12:36

Mario-DL mentioned this pull request May 9, 2024

[20827] Fix python tests - playground #4731

Closed

15 tasks

mergify bot mentioned this pull request May 9, 2024

[20965] Fix Python Installation version in Github CI. Address failing system tests environment issues. (backport #4759) #4766

Merged

8 tasks

Mario-DL mentioned this pull request May 13, 2024

[21009] Do not require PYTHON_VERSION to be defined in .bat files #4770

Merged

8 tasks

mergify bot mentioned this pull request May 17, 2024

[21009] Do not require PYTHON_VERSION to be defined in .bat files (backport #4770) #4797

Merged

8 tasks

mergify bot mentioned this pull request May 17, 2024

[21009] Do not require PYTHON_VERSION to be defined in .bat files (backport #4770) #4798

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20965] Fix Python Installation version in Github CI. Address failing system tests environment issues.#4759

[20965] Fix Python Installation version in Github CI. Address failing system tests environment issues.#4759
EduPonz merged 4 commits intomasterfrom
hotfix/20965

Mario-DL commented May 8, 2024 •

edited by JesusPoderoso

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

JesusPoderoso commented May 9, 2024

Uh oh!

JesusPoderoso left a comment

Uh oh!

EduPonz commented May 9, 2024

Uh oh!

mergify bot commented May 9, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Mario-DL commented May 8, 2024 • edited by JesusPoderoso Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

This comment was marked as outdated.

Uh oh!

JesusPoderoso commented May 9, 2024

Uh oh!

JesusPoderoso left a comment

Choose a reason for hiding this comment

Uh oh!

EduPonz commented May 9, 2024

Uh oh!

mergify bot commented May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mario-DL commented May 8, 2024 •

edited by JesusPoderoso

Loading

mergify bot commented May 9, 2024 •

edited

Loading