[20511] Remove use of deprecated FindPythonInterp#4447
Merged
Conversation
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
This was referenced Feb 24, 2024
Author
|
@richiprosima please test this |
Mario-DL
pushed a commit
that referenced
this pull request
May 10, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
8 tasks
Mario-DL
pushed a commit
that referenced
this pull request
May 10, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
8 tasks
Mario-DL
pushed a commit
that referenced
this pull request
May 10, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
8 tasks
EduPonz
added a commit
that referenced
this pull request
May 13, 2024
…tests environment issues (#4759) (#4764) * Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) * Remove use of deprecated FindPythonInterp (#4447) Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
May 17, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
May 17, 2024
…tests environment issues. (#4759, #4447, #4770) (#4765) * Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) # Conflicts: # test/system/tools/fastdds/CMakeLists.txt * Solve conflicts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Remove use of deprecated FindPythonInterp (#4447) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Add missing Python3_executable communication test command Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Do not require PYTHON_VERSION to be defined in .bat files (#4770) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
May 20, 2024
…tests environment issues (#4759) (#4766) * Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) # Conflicts: # test/system/tools/fastdds/CMakeLists.txt * Solve conflicts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Remove use of deprecated FindPythonInterp (#4447) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Add missing Python3_executable communication test command Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Do not require PYTHON_VERSION to be defined in .bat files (#4770) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FindPythonInterphas been deprecated since CMake 3.12. This PR finds the python interpreter within CMake files using the supportedFindPython3. This change if motivated by the intention of supporting Ubuntu 24.04, that ships CMake 3.28.3, version in which a CMake warning aboutFindPythonInterpis shown; this warning was introduced in CMake 3.27.Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist