Conversation
…tests environment issues (#4759) * Refs #20965: Install a fix python version in ubuntu and windows cis Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Decide Python environment depending on the version Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20965: Add some comments Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 3b2e781) # Conflicts: # test/system/tools/fastdds/CMakeLists.txt
Contributor
Author
|
Cherry-pick of 3b2e781 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
8 tasks
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Contributor
|
Added cherry-pick from #4447 |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Contributor
|
@richiprosima please test this |
8 tasks
This was referenced May 17, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Contributor
|
@richiprosima please test windows |
Mario-DL
approved these changes
May 20, 2024
Contributor
|
This last CI was launched in windows as the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses failing github CI system tests.
.battool files by means of an environment variablePYTHON_VERSION{Major.Minor}.Qtfrom setting-up Python, as we are who manage the Python installationNotes:
pywin32is not listed as a required python package at thePython Dependenciesstep as it is a requirement ofcolconand it is installed along with it.Work done in #4731 precedes this PR.
@Mergifyio backport 2.13.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A Changes are ABI compatible.
N/A Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4759 done by [Mergify](https://mergify.com).