[16737] Fix StatelessWriter ACK check#3234
Merged
MiguelCompany merged 4 commits intomasterfrom Jan 24, 2023
Merged
Conversation
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Contributor
Author
|
@Mergifyio backport 2.9.x 2.8.x 2.7.x 2.6.x |
Contributor
✅ Backports have been createdDetails
|
Contributor
Author
|
Failures seem unrelated to changes (in fact I do not think this is tested anywhere in Fast DDS test suite). |
Member
MiguelCompany
left a comment
There was a problem hiding this comment.
I think @richiware should also review this
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
9 tasks
MiguelCompany
requested changes
Jan 23, 2023
Member
MiguelCompany
left a comment
There was a problem hiding this comment.
After reviewing this with @richiware, there are two additional changes needed
…cknowledgements Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Contributor
Author
|
@richiprosima please test this |
MiguelCompany
requested changes
Jan 23, 2023
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Contributor
Author
|
@richiprosima please test this |
MiguelCompany
approved these changes
Jan 23, 2023
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Refs #16737: fix StatelessWriter ack check Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions: fix notification to wait for acknowledgements Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> (cherry picked from commit 86125f5)
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Refs #16737: fix StatelessWriter ack check Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions: fix notification to wait for acknowledgements Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> (cherry picked from commit 86125f5)
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Refs #16737: fix StatelessWriter ack check Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions: fix notification to wait for acknowledgements Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> (cherry picked from commit 86125f5)
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Refs #16737: fix StatelessWriter ack check Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions: fix notification to wait for acknowledgements Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> (cherry picked from commit 86125f5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com
Description
StatelessWriter::is_acked_by_allchecks that the sample has been delivered but instead of checking that the sequence number is lower than the last sent, the contrary is checked. This PR fixes this and other places where this same issue is happening.@Mergifyio backport 2.9.x 2.8.x 2.7.x 2.6.x
Contributor Checklist
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Documentation builds and tests pass locally.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Reviewer Checklist