[16737] Fix StatelessWriter ACK check (backport #3234)#3244
Merged
MiguelCompany merged 1 commit into2.6.xfrom Jan 24, 2023
Merged
[16737] Fix StatelessWriter ACK check (backport #3234)#3244MiguelCompany merged 1 commit into2.6.xfrom
MiguelCompany merged 1 commit into2.6.xfrom
Conversation
* Refs #16737: fix StatelessWriter ack check Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions: fix notification to wait for acknowledgements Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #16737: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> (cherry picked from commit 86125f5)
9 tasks
MiguelCompany
approved these changes
Jan 24, 2023
Member
|
@richiprosima Please test mac |
1 similar comment
Member
|
@richiprosima Please test mac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3234 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com