Add Quality Declaration and update README [9371] by JLBuenoLopez · Pull Request #1400 · eProsima/Fast-DDS

JLBuenoLopez · 2020-09-21T15:02:19Z

For more info about the code style, please refer to eProsima/code-style#3

For more info about CONTRIBUTING and VULNERABILITY policies, please refer to https://github.com/eProsima/policies

For more information about Fast CDR Quality Declaration, please refer to https://github.com/eProsima/Fast-CDR/blob/master/QUALITY.md

For more information about foonathan_memory Quality Declaration, please refer to https://github.com/eProsima/Fast-DDS/blob/master/Quality_Declaration_foonathan_memory.md

Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

brawner

Looks good except for a couple of minor typos

QUALITY.md

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: brawner <brawner@gmail.com>

EduPonz

LGTM

chapulina · 2020-10-16T16:24:45Z

@JLBuenoLopez-eProsima , thank you for the effort your team has done so far to address REP-2004.

We noticed that the quality declaration was merged into the master branch. Would it be possible to port it to branch 2.0.x, which is used by Foxy and Rolling? Does this declaration hold true for that branch too?

Thanks!

MiguelCompany · 2020-10-21T14:28:37Z

@chapulina

For Rolling, we are planning to request using our master branch, as bugfixes will usually land there first, and having REP-2004 in place means we are bound to avoid API and ABI breaks.
Regarding Foxy, we are going to release 2.1.0 soon, which will be the first minor release with REP-2004 in place, and will have some cool new features like discovery service v2, big performance improvements on intra-process, and SHM transport active by default

chapulina · 2020-10-21T16:44:46Z

Nice! Thanks for the update, @MiguelCompany !

Regarding Foxy, we are going to release 2.1.0 soon, which will be the first minor release with REP-2004 in place

Does this mean that you plan to change the branch on rosdistro, which is 2.0.x for Foxy?

My main concern right now is to add links to the correct quality declaration on downstream libraries. We're adding declarations to Foxy branches, but we don't have a Foxy Fast-DDS declaration to point to. We'd like to link to it here for example.

* Refs #9371: Add Quality Declaration and update README Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: correct typos Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update external dependencies Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update status summary Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update QD Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update QD, foonathan dependency Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Apply suggestions from code review Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: brawner <brawner@gmail.com> Co-authored-by: brawner <brawner@gmail.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

@brawner

* Added document with supported platforms (#1397) * Refs #9263: added document with supported platforms Signed-off-by: imontesino <monte.igna@gmail.com> * Refs #9263: Applied suggested changes Signed-off-by: imontesino <monte.igna@gmail.com> * Refs #9263: Changed filename Signed-off-by: imontesino <monte.igna@gmail.com> * Refs #9263: removed windows arm32 reference Signed-off-by: imontesino <monte.igna@gmail.com> * Changed title Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Add foonathan public API document (#1403) * Refs #9394: Add foonathan public API document Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Update Public_API_foonathan_memory.md Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Add CI labels to README Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Add Quality Declaration for foonathan_memory external dependency (#1404) * Refs #9391: Add Foonathan Quality Declaration Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9391: Update Foonathan QD Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9398: Add review suggestions by Ignacio Montesino. Change Linux-aarch64 badges Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9398: apply review comments by @brawner Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Apply suggestions from code review Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Add Quality Declaration and update README [9371] (#1400) * Refs #9371: Add Quality Declaration and update README Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: correct typos Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update external dependencies Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update status summary Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update QD Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update QD, foonathan dependency Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Apply suggestions from code review Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: brawner <brawner@gmail.com> Co-authored-by: brawner <brawner@gmail.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Fixed broken link to FastCDR Quality.md (#1443) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Ignacio Montesino Valle <ignamonte@hotmail.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: brawner <brawner@gmail.com> Co-authored-by: Johnny Willemsen <jwillemsen@remedy.nl>

JLBuenoLopez · 2020-10-26T14:23:20Z

@chapulina,

Last Friday, the Quality Declaration and all related documents were backported to 2.0.x. More information can be found in #1514.

chapulina · 2020-10-26T16:56:12Z

Great to hear, @JLBuenoLopez-eProsima . Thanks!

JLBuenoLopez added the no-test Skip CI tests if PR marked with this label label Sep 21, 2020

JLBuenoLopez changed the title ~~Add Quality Declaration and update README~~ Add Quality Declaration and update README [9371] Sep 22, 2020

MiguelCompany requested a review from EduPonz September 22, 2020 14:27

JLBuenoLopez added 6 commits September 23, 2020 15:18

Refs #9371: Add Quality Declaration and update README

b828b4c

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #9371: correct typos

1383a66

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #9371: Update external dependencies

d0d4868

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #9371: Update status summary

f68a436

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #9371: Update QD

b5e6612

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Refs #9371: Update QD, foonathan dependency

13313c8

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

JLBuenoLopez force-pushed the feature/QD branch from aa69ee0 to 13313c8 Compare September 23, 2020 13:19

EduPonz mentioned this pull request Sep 23, 2020

Fast-RTPS external dependency Quality Declaration ros2/rmw_fastrtps#357

Closed

brawner previously approved these changes Sep 23, 2020

View reviewed changes

QUALITY.md Outdated Show resolved Hide resolved

QUALITY.md Outdated Show resolved Hide resolved

Apply suggestions from code review

e76a3d9

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: brawner <brawner@gmail.com>

JLBuenoLopez dismissed brawner’s stale review via e76a3d9 September 24, 2020 11:51

EduPonz approved these changes Sep 30, 2020

View reviewed changes

EduPonz merged commit 55003e3 into master Sep 30, 2020

EduPonz deleted the feature/QD branch September 30, 2020 07:58

chapulina mentioned this pull request Sep 30, 2020

Update rmw_fastrtps_cpp and rmw_fastrtps_shared_cpp QDs to QL2. ros2/rmw_fastrtps#456

Merged

JLBuenoLopez mentioned this pull request Oct 23, 2020

Backport Quality Declaration to <2.0.x> [9723] #1514

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Quality Declaration and update README [9371]#1400

Add Quality Declaration and update README [9371]#1400
EduPonz merged 7 commits intomasterfrom
feature/QD

JLBuenoLopez commented Sep 21, 2020 •

edited by EduPonz

Loading

Uh oh!

brawner left a comment

Uh oh!

Uh oh!

Uh oh!

EduPonz left a comment

Uh oh!

chapulina commented Oct 16, 2020 •

edited

Loading

Uh oh!

MiguelCompany commented Oct 21, 2020

Uh oh!

chapulina commented Oct 21, 2020

Uh oh!

JLBuenoLopez commented Oct 26, 2020 •

edited

Loading

Uh oh!

chapulina commented Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JLBuenoLopez commented Sep 21, 2020 • edited by EduPonz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brawner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

EduPonz left a comment

Choose a reason for hiding this comment

Uh oh!

chapulina commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MiguelCompany commented Oct 21, 2020

Uh oh!

chapulina commented Oct 21, 2020

Uh oh!

JLBuenoLopez commented Oct 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chapulina commented Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JLBuenoLopez commented Sep 21, 2020 •

edited by EduPonz

Loading

chapulina commented Oct 16, 2020 •

edited

Loading

JLBuenoLopez commented Oct 26, 2020 •

edited

Loading