Add Quality Declaration for foonathan_memory external dependency [9398]#1404
Merged
MiguelCompany merged 5 commits intomasterfrom Sep 28, 2020
Merged
Add Quality Declaration for foonathan_memory external dependency [9398]#1404MiguelCompany merged 5 commits intomasterfrom
MiguelCompany merged 5 commits intomasterfrom
Conversation
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
foonathan_memory external dependency
imontesino
suggested changes
Sep 23, 2020
…-aarch64 badges Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
imontesino
previously approved these changes
Sep 23, 2020
Contributor
|
LGTM |
brawner
previously approved these changes
Sep 23, 2020
Contributor
brawner
left a comment
There was a problem hiding this comment.
Looks good to me. Are you all planning on pushing this package to "quality level 1" equivalent?
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
02ae1c5
MiguelCompany
requested changes
Sep 28, 2020
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
approved these changes
Sep 28, 2020
JLBuenoLopez
added a commit
that referenced
this pull request
Oct 23, 2020
* Refs #9391: Add Foonathan Quality Declaration Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9391: Update Foonathan QD Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9398: Add review suggestions by Ignacio Montesino. Change Linux-aarch64 badges Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9398: apply review comments by @brawner Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Apply suggestions from code review Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Oct 23, 2020
* Added document with supported platforms (#1397) * Refs #9263: added document with supported platforms Signed-off-by: imontesino <monte.igna@gmail.com> * Refs #9263: Applied suggested changes Signed-off-by: imontesino <monte.igna@gmail.com> * Refs #9263: Changed filename Signed-off-by: imontesino <monte.igna@gmail.com> * Refs #9263: removed windows arm32 reference Signed-off-by: imontesino <monte.igna@gmail.com> * Changed title Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Add foonathan public API document (#1403) * Refs #9394: Add foonathan public API document Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Update Public_API_foonathan_memory.md Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Add CI labels to README Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Add Quality Declaration for foonathan_memory external dependency (#1404) * Refs #9391: Add Foonathan Quality Declaration Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9391: Update Foonathan QD Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9398: Add review suggestions by Ignacio Montesino. Change Linux-aarch64 badges Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9398: apply review comments by @brawner Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Apply suggestions from code review Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Add Quality Declaration and update README [9371] (#1400) * Refs #9371: Add Quality Declaration and update README Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: correct typos Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update external dependencies Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update status summary Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update QD Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #9371: Update QD, foonathan dependency Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Apply suggestions from code review Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: brawner <brawner@gmail.com> Co-authored-by: brawner <brawner@gmail.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Fixed broken link to FastCDR Quality.md (#1443) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Ignacio Montesino Valle <ignamonte@hotmail.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: brawner <brawner@gmail.com> Co-authored-by: Johnny Willemsen <jwillemsen@remedy.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information about Foonathan API used by eprosima Fast DDS, please refer to #1403