Merged
Conversation
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
lauramg15
suggested changes
Sep 16, 2020
Member
|
I think the whole @eProsima/team should review this |
IkerLuengo
suggested changes
Sep 16, 2020
README.md
Outdated
|
|
||
| Namespaces do not add an extra level of indentation. | ||
|
|
||
| There should be a comment after the closing brace of the namespace, even more if the scope of the namespace is great enough and there may be doubts about which namespace is being closed. |
Contributor
There was a problem hiding this comment.
Suggested change
| There should be a comment after the closing brace of the namespace, even more if the scope of the namespace is great enough and there may be doubts about which namespace is being closed. | |
| There should be a comment after the closing brace of the namespace, as if the scope of the namespace is great enough, there may be doubts about which namespace is being closed. |
This was referenced Sep 21, 2020
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: laura <52071480+laura-eprosima@users.noreply.github.com> Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com>
…rLuengo Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
LuisGP
suggested changes
Sep 28, 2020
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
LuisGP
previously approved these changes
Sep 30, 2020
lauramg15
previously approved these changes
Sep 30, 2020
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
MiguelCompany
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate README and update information according to the uncrustify.cfg file