Enable stack traces on linux for bundled libraries#18363
Merged
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom Jul 22, 2025
Merged
Enable stack traces on linux for bundled libraries#18363Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom
Conversation
Contributor
|
@Mytherin has more context on why that's not the default on Linux (speed? size? portability?) |
Collaborator
|
I lost that context some time ago :) I think there's not a particular reason - at the time I just didn't want to risk breaking anything by setting it as a default |
carlopi
approved these changes
Jul 22, 2025
Contributor
carlopi
left a comment
There was a problem hiding this comment.
Then I guess this is a best place where to experiment than others. LGTM.
One question is why we use bundled_libraries.cmake, does that mean we ship tpch code?
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 23, 2025
More robustness around deprecated extension settings (duckdb/duckdb#18353) Enable stack traces on linux for bundled libraries (duckdb/duckdb#18363) Re-enable url-encode test (duckdb/duckdb#18360)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 23, 2025
More robustness around deprecated extension settings (duckdb/duckdb#18353) Enable stack traces on linux for bundled libraries (duckdb/duckdb#18363) Re-enable url-encode test (duckdb/duckdb#18360) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we want to do the same for the main distribution binaries?
Currently, linux stack traces look like this:
See this PR, which added the flag: #15587
Related issue: https://github.com/duckdblabs/duckdb-internal/issues/5364