More robustness around deprecated extension settings#18353
Merged
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom Jul 23, 2025
Merged
More robustness around deprecated extension settings#18353Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom
Conversation
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 23, 2025
More robustness around deprecated extension settings (duckdb/duckdb#18353) Enable stack traces on linux for bundled libraries (duckdb/duckdb#18363) Re-enable url-encode test (duckdb/duckdb#18360)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 23, 2025
More robustness around deprecated extension settings (duckdb/duckdb#18353) Enable stack traces on linux for bundled libraries (duckdb/duckdb#18363) Re-enable url-encode test (duckdb/duckdb#18360) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
Mechanism for autoloading setting currently assumes a given extension is stable over time and always provide the same set of settings (or that they grow over time, adding them is fine).
While this is currently true, as far as I am aware, it might not something we want (or can) guarantee moving forward.
Currently, if you were to remove a setting from an extension, compile it from a duckdb version that assumes the setting to be there, and allow autoloading:
while with assertion enabled it would be caught by:
D_ASSERT(entry != config.extension_parameters.end());Proposed change
This PR turns the assertion in a runtime InternalException, that is strictly better than segfault.
Open questions/1: InternalException or InvalidInputException
We could consider move InternalException to InvalidInputException, problem is that executing the SQL still has the side effect of autoinstall / autoloading the extension, so it would be handy to broadcast that to the user (and while InternalException are always rethrown, that's not true for other exception types).
Open questions/2: how to test
Code is more or less trivial, problem is that this is very hard to test without extra infrastructure.
What I did locally was compile on a hash where
httpfsextension was available, so to be able to use defaulthttpfswe ship, add a phantom setting via:and then check behaviour of:
or