Clean-up stack traces on MacOS, fix demangling on Linux, and add EXPORT_DYNAMIC_SYMBOLS flag which enables stack traces on Linux#15587
Merged
Mytherin merged 7 commits intoduckdb:mainfrom Jan 7, 2025
Conversation
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jan 7, 2025
Clean-up stack traces on MacOS, fix demangling on Linux, and add `EXPORT_DYNAMIC_SYMBOLS` flag which enables stack traces on Linux (duckdb/duckdb#15587) HTTPFS test - no longer check for IS NOT NULL filter as this is no longer necessary (duckdb/duckdb#15585)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jan 7, 2025
Clean-up stack traces on MacOS, fix demangling on Linux, and add `EXPORT_DYNAMIC_SYMBOLS` flag which enables stack traces on Linux (duckdb/duckdb#15587) HTTPFS test - no longer check for IS NOT NULL filter as this is no longer necessary (duckdb/duckdb#15585) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Mytherin
added a commit
that referenced
this pull request
Jul 22, 2025
Not sure if we want to do the same for the main distribution binaries? Currently, linux stack traces look like this: ``` ./dist/myprogram() [0x25c97a6] ./dist/myprogram() [0x25c9864] ./dist/myprogram() [0x25cc6b9] ./dist/myprogram() [0x1e5ee8e] ``` See this PR, which added the flag: #15587 Related issue: duckdblabs/duckdb-internal#5364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPORT_DYNAMIC_SYMBOLSflag which exports symbols, allowing stack traces to be printed on Linux as well