Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7172c68
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8b9e708
Choose a head ref
  • 16 commits
  • 319 files changed
  • 11 contributors

Commits on Jan 4, 2022

  1. logging (#63326)

    danmoseley authored Jan 4, 2022
    Configuration menu
    Copy the full SHA
    312c66f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef357af View commit details
    Browse the repository at this point in the history
  3. Divide properties into: public, private, protected. (#62627)

    * Description of DebuggerBrowsable behavior.
    
    * Added test for browse attributes.
    
    * Corrected typos in the doc.
    
    * Added Browse Never feature. Corrected Collapse test. ToDo: RootHidden.
    
    * Draft of RootHidden solution.
    
    * Added Array to test cases as it behaves differently than Collection.
    
    * Added name concatenation to make array/list elemetns in debug window unique.
    
    * Update docs/design/mono/debugger.md
    
    Co-authored-by: Ankit Jain <radical@gmail.com>
    
    * Applied PR review suggestions.
    
    * Added a reference to regular Browsable attribute behavior in .net.
    
    * Applied most of review suggestions.
    
    * Stopping GetFieldsValue early.
    
    * Remove unintentional change to the original code.
    
    * Do not skip fields that don't have browsable attributes.
    
    * Changing the expected behavior to match Console Application. EventHandlers are Browsable.Never by default.
    
    * Changed the place of checking if objetc is an array.
    
    * Update src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
    
    Co-authored-by: Ankit Jain <radical@gmail.com>
    
    * Removed unused variables.
    
    * Removing space and unused import.
    
    * Draft - parameter for choosing sorted and unsorted returned value version.
    
    * Working version.
    
    * Added "protected internal" and "private protected" cases. Changed field name to be consistant with the value.
    
    * Changed approach: placed sorting at the end of the function, not in the middle.
    
    * Fix for tests that use GetProperties.
    
    * Fixed most tests (31 failing).
    
    * Removed whitespaces.
    
    * Fixed CheckAccessorsOnObjectsWithCFO tests.
    
    * Fix for InspectTypeInheritedMembers.
    
    * Revert unnecessary indent change.
    
    * Partially addressed @radical comments.
    
    * Addressed the comment about extension instead of Union.
    
    * Removed string cultural vunerability.
    
    * Added Properties dictionary, the same as for fields.
    
    * Fixed the bug I made by using dynamc.
    
    * Applying @radical comments about refactoring.
    
    * Corrected typo.
    
    * Added tests for properties.
    
    * Draft of changes for properties handling - never and root hidden failing.
    
    * Fix for RootHidden properties.
    
    * Added tests for static fields decorated with Browsable.
    
    * Correct a typo.
    
    * Undo merge unintentional changes.
    
    * Changing expected behavior for MulticastDelegateTest - in Console Application EventHandler is Browsable.Never by default so we should not expect it to be visible in the debug window.
    
    * Removing not relevant changes created after merge with main.
    
    * Remove file added in merge with main.
    
    * Revert "Removing not relevant changes created after merge with main."
    
    This reverts commit b1acf8b.
    
    * Revert.
    
    * Revert revert.
    
    * One broken test for custom getter.
    
    * Ugly fix to make all the tests work.
    
    * Refactored JArray aggregation to Dictionary.
    
    * Better naming.
    
    * Add skipped change from merge.
    
    * Fix getters testing.
    
    * Removed unnecessary doubled execution.
    
    * Decreased complexity by replacing a loop with data aggregation.
    
    * Replaced O(nm) Linq with O(n) loop through dictionary.
    
    * Remove comment, flip conditions.
    
    * Removed not intended comments and changes.
    
    * Missing removal for previous commit.
    
    * Added tests for protection levels.
    
    Co-authored-by: Ankit Jain <radical@gmail.com>
    ilonatommy and radical authored Jan 4, 2022
    Configuration menu
    Copy the full SHA
    ae2e360 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b2ab353 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    932c822 View commit details
    Browse the repository at this point in the history
  6. Disable console test for jitstressreg mode (#63349)

    * Revert "logging (#63326)"
    
    This reverts commit 312c66f.
    
    * disable test for jit stress regs
    danmoseley authored Jan 4, 2022
    Configuration menu
    Copy the full SHA
    33731fc View commit details
    Browse the repository at this point in the history
  7. Enable support for nint/nuint for Vector64/128/256<T> (#63329)

    * Enable support for nint/nuint for Vector64/128/256<T>
    
    * Adding the additional Vector64/128/256<T> APIs required to support nint/nuint
    
    * Removing the "NotSupported" tests for nint/nuint of Vector64/128/256<T>
    tannergooding authored Jan 4, 2022
    Configuration menu
    Copy the full SHA
    eed3a62 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4a1bcc3 View commit details
    Browse the repository at this point in the history
  9. clean up header collection property implementations (#63308)

    Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
    geoffkizer and Geoffrey Kizer authored Jan 4, 2022
    Configuration menu
    Copy the full SHA
    4514589 View commit details
    Browse the repository at this point in the history
  10. Pass configuration as a parameter for local Apple mobile test runs (#…

    …63348)
    
    Reverts #62549 as the configuration parameter is needed to let xharness know where the iOS/tvOS/MacCatalyst test app is.
    
    For example, a debug test app will be under Debug-iphoneos and a release one will be under Release-iphoneos. Xharness won't be able to tell unless provided the right info.
    steveisok authored Jan 4, 2022
    Configuration menu
    Copy the full SHA
    00952e1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8ce1c54 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Configuration menu
    Copy the full SHA
    5b17bec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0524b58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a9bd5c View commit details
    Browse the repository at this point in the history
  4. Move HttpRequestStream.{Begin}Read argument logging to after validati…

    …on (#63362)
    
    It's after validation on the HttpResponseStream corresponding methods, and having it before the validation means it'll null ref if a null buffer is erroneously provided.
    stephentoub authored Jan 5, 2022
    Configuration menu
    Copy the full SHA
    b6695a1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8b9e708 View commit details
    Browse the repository at this point in the history
Loading