[tests] Fix local test runs for mobile#62549
Merged
MaximLipnin merged 1 commit intodotnet:mainfrom Dec 9, 2021
Merged
Conversation
|
Tagging subscribers to this area: @directhex Issue DetailsFixes #62161 An extra /cc @vcsjones @steveisok @premun
|
MaximLipnin
approved these changes
Dec 9, 2021
steveisok
pushed a commit
to steveisok/runtime
that referenced
this pull request
Jan 4, 2022
dotnet#62549 removed the parameter as it's needed to let xharness know where the iOS/tvOS/MacCatalyst test app is. For example, a debug test app will be under Debug-iphoneos and a release one will be under Release-iphoneos. Xharness won't be able to tell unless provided the right info.
steveisok
added a commit
that referenced
this pull request
Jan 4, 2022
…63348) Reverts #62549 as the configuration parameter is needed to let xharness know where the iOS/tvOS/MacCatalyst test app is. For example, a debug test app will be under Debug-iphoneos and a release one will be under Release-iphoneos. Xharness won't be able to tell unless provided the right info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62161
An extra
AdditionalXHarnessArgumentshad been introduced in #59503 that is not an XHarness argument found in https://github.com/dotnet/xharness/tree/main/src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Arguments. This PR will fix local mobile test runs by removing that Property./cc @vcsjones @steveisok @premun