Pass configuration as a parameter for local Apple mobile test runs#63348
Pass configuration as a parameter for local Apple mobile test runs#63348steveisok merged 1 commit intodotnet:mainfrom
Conversation
dotnet#62549 removed the parameter as it's needed to let xharness know where the iOS/tvOS/MacCatalyst test app is. For example, a debug test app will be under Debug-iphoneos and a release one will be under Release-iphoneos. Xharness won't be able to tell unless provided the right info.
|
Tagging subscribers to this area: @directhex Issue DetailsReverts #62549 as the configuration parameter is needed to let xharness know where the iOS/tvOS/MacCatalyst test app is. For example, a debug test app will be under Debug-iphoneos and a release one will be under Release-iphoneos. Xharness won't be able to tell unless provided the right info.
|
|
|
||
| <PropertyGroup Condition="'$(TargetsMobile)' == 'true'"> | ||
| <RunTestsCommand>"$(RunScriptOutputPath)" $(AssemblyName) $(TargetArchitecture) $(TargetOS.ToLowerInvariant()) $(TestProjectName)</RunTestsCommand> | ||
| <RunTestsCommand Condition="'$(TargetsAppleMobile)' == 'true'">$(RunTestsCommand) $(Configuration) $(AdditionalXHarnessArguments)</RunTestsCommand> |
There was a problem hiding this comment.
Does $(Configuration) need to be before the AdditionalXHarnessArguments? Otherwise we can move it to the first line and remove the RunTestsCommand conditioned for Android.
There was a problem hiding this comment.
Yeah, it does. It's technically an argument into https://github.com/dotnet/runtime/blob/main/eng/testing/AppleRunnerTemplate.sh and not into xharness.
Reverts #62549 as the configuration parameter is needed to let xharness know where the iOS/tvOS/MacCatalyst test app is.
For example, a debug test app will be under Debug-iphoneos and a release one will be under Release-iphoneos. Xharness won't be able to tell unless provided the right info.