Skip to content

Implement IEquatable<T> on the runtime handle types.#63358

Merged
jkotas merged 1 commit intodotnet:mainfrom
teo-tsirpanis:runtimehandles-iequatable
Jan 5, 2022
Merged

Implement IEquatable<T> on the runtime handle types.#63358
jkotas merged 1 commit intodotnet:mainfrom
teo-tsirpanis:runtimehandles-iequatable

Conversation

@teo-tsirpanis
Copy link
Contributor

I also called the Equals method via the interface in the tests.

Fixes Contributes to #62944.

@ghost
Copy link

ghost commented Jan 4, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jan 4, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

I also called the Equals method via the interface in the tests.

Fixes Contributes to #62944.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Runtime, new-api-needs-documentation, community-contribution

Milestone: -

@jkotas
Copy link
Member

jkotas commented Jan 4, 2022

You should be also able delete these baseline exclusions: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime/src/MatchingRefApiCompatBaseline.txt#L28

@teo-tsirpanis teo-tsirpanis force-pushed the runtimehandles-iequatable branch from 4201f3f to a181c14 Compare January 4, 2022 21:34
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jkotas jkotas merged commit 8b9e708 into dotnet:main Jan 5, 2022
@teo-tsirpanis teo-tsirpanis deleted the runtimehandles-iequatable branch January 5, 2022 10:32
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants