-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Comparing changes
Open a pull request
base repository: dotnet/runtime
base: 33cb335
head repository: dotnet/runtime
compare: 5108757
- 15 commits
- 89 files changed
- 10 contributors
Commits on Oct 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e232f79 - Browse repository at this point
Copy the full SHA e232f79View commit details -
Add ReadOnly{Observable}Collection/Dictionary.Empty (#76764)
* Add ReadOnly{Observable}Collection/Dictionary.Empty * Revert XamlLoadPermission.cs change to fix downlevel buildConfiguration menu - View commit details
-
Copy full SHA for bbcff6b - Browse repository at this point
Copy the full SHA bbcff6bView commit details -
SmtpClientTest Assertion Fail Fix (#76361)
* Eliminate temporary -1 on Socket.Unix.cs
Configuration menu - View commit details
-
Copy full SHA for c092a76 - Browse repository at this point
Copy the full SHA c092a76View commit details -
SPMI: Fix repPrintObjectDescription and repGetStringLiteral (#77372)
repPrintObjectDescription was not null-terminating when the map was null. There is SPMI error trap on the JIT side so we can just make it fail on missing data. repGetStringLiteral should not succeed on missing data, it is used for optimization purposes.
Configuration menu - View commit details
-
Copy full SHA for 1c265ec - Browse repository at this point
Copy the full SHA 1c265ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58a1180 - Browse repository at this point
Copy the full SHA 58a1180View commit details -
Update def flags in gtCloneExpr (#77378)
Limit to cases where are actually performing replacements to mitigate TP impact.
Configuration menu - View commit details
-
Copy full SHA for cc140fc - Browse repository at this point
Copy the full SHA cc140fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d8379d - Browse repository at this point
Copy the full SHA 2d8379dView commit details -
[wasm] Add
IMemoryViewas exported type (#77371)- Add IMemoryView as exported type. - IMemoryView extends IDisposable.
Configuration menu - View commit details
-
Copy full SHA for 41db775 - Browse repository at this point
Copy the full SHA 41db775View commit details -
Fold primitive-typed access to promoted structs in local morph and fo…
…rbid mismatched struct assignments (#76766) * GenTree::GetLayout field FIELDs * Do not create invalid IR when replacing promoted fields Instead, create constructions like "OBJ(ADDR(LCL_VAR))" that block morphing can recognize on its own. * Delete lvFieldHnd * GenTree::GetLayout - CALL/COMMA * GenTreeHWIntrinsic::GetLayout * Add an assert that LHS and RHS match * Fix assert violation And simplify the code... * Delete RetypedAsScalarFieldsMap Without handle equality, the assert no longer holds, for example: ```cs private StructWithInt Problem(StructWithInt b, StructWithInt a) { a = ((StructWithStructWithInt*)&b)->StructWithInt; return a; } ``` * Delete a bit of code Dead / unncessary. No diffs. * Fold promoted locals in local morph * Support GT_IND in MorphStructField This is significantly simpler than moving the promotion logic to post-order because we don't need to fiddle with the ref counting process and complexities of intermediate states, e. g. "IND<float>(ADDR(FIELD<int>(ADDR(LCL_VAR<struct>))))" can be naturally turned into "BITCAST<float>(LCL_VAR<int>)" like this. * More code removal * Move "fgMorphStructField" to local morph * TP tuning With this, we have only a very small regression: Base: 1297463478, Diff: 1297750893, +0.0222% LocalAddressVisitor::MorphStructField : 345099 : NA : 31.52% : +0.0266% LocalAddressVisitor::PreOrderVisit : 224684 : +3.53% : 20.52% : +0.0173% memset : 88591 : +0.99% : 8.09% : +0.0068% Compiler::fgMorphSmpOp : -19170 : -0.06% : 1.75% : -0.0015% Compiler::fgMorphStructField : -367474 : -100.00% : 33.56% : -0.0283% (This is with a dummy field on LclVarDsc) Losing the assert does not seem worrysome as we have an identical one in "fgMorphField".
Configuration menu - View commit details
-
Copy full SHA for 76cf397 - Browse repository at this point
Copy the full SHA 76cf397View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c0102d - Browse repository at this point
Copy the full SHA 0c0102dView commit details -
Detriplicate internal SingleProducerSingleConsumerQueue (#76932)
System.Private.CoreLib, System.Threading.Tasks.Dataflow, and System.Threading.Channels have all ended up with their own copy of SingleProducerSingleConsumerQueue and its associated helpers. This consolidates them down to a single shared copy. There's no functional change here, just deleting duplicates and moving things around.
Configuration menu - View commit details
-
Copy full SHA for 70fb135 - Browse repository at this point
Copy the full SHA 70fb135View commit details -
Fix reported PriorityQueue issue. (#77229)
* Fix #77212. * Remove unneeded using statement.
Configuration menu - View commit details
-
Copy full SHA for 090003a - Browse repository at this point
Copy the full SHA 090003aView commit details -
SPMI: More information on CI failures (#77361)
This enhances parts of the SPMI process with more information on failures. Also fixes a bug I introduced when I added tpdiffs: when asmdiffs fails, it was not marking the entire pipeline as failing.
Configuration menu - View commit details
-
Copy full SHA for 9290f85 - Browse repository at this point
Copy the full SHA 9290f85View commit details
Commits on Oct 25, 2022
-
Consolidate the
GUIDto string logic (#77394)* Consolidate the GUID to string logic Replace obvious uses of GUID to string logic with a new constant for buffer length.
Configuration menu - View commit details
-
Copy full SHA for a394aea - Browse repository at this point
Copy the full SHA a394aeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5108757 - Browse repository at this point
Copy the full SHA 5108757View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 33cb335...5108757