SPMI: Fix repPrintObjectDescription and repGetStringLiteral#77372
Merged
jakobbotsch merged 1 commit intodotnet:mainfrom Oct 24, 2022
Merged
SPMI: Fix repPrintObjectDescription and repGetStringLiteral#77372jakobbotsch merged 1 commit intodotnet:mainfrom
jakobbotsch merged 1 commit intodotnet:mainfrom
Conversation
repPrintObjectDescription was not null-terminating when the map was null. There is SPMI error trap on the JIT side so we can just make it fail on missing data. repGetStringLiteral should not succeed on missing data, it is used for optimization purposes.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsrepPrintObjectDescription was not null-terminating when the map was null. There is SPMI error trap on the JIT side so we can just make it fail on missing data. repGetStringLiteral should not succeed on missing data, it is used for optimization purposes.
|
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo This should fix recent superpmi-diffs failures where no results are reported sometimes. |
EgorBo
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repPrintObjectDescription was not null-terminating when the map was null. There is SPMI error trap on the JIT side so we can just make it fail on missing data.
repGetStringLiteral should not succeed on missing data, it is used for optimization purposes. I noticed this one while fixing the other one.