Fix reported PriorityQueue issue.#77229
Merged
eiriktsarpalis merged 2 commits intodotnet:mainfrom Oct 24, 2022
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-collections Issue Detailsnull
|
eiriktsarpalis
commented
Oct 19, 2022
| ArgumentNullException.ThrowIfNull(elements); | ||
|
|
||
| int count; | ||
| if (elements is ICollection<(TElement Element, TPriority Priority)> collection && |
Member
Author
There was a problem hiding this comment.
This was previously checking for the wrong ICollection type resulting in the optimization never being used.
krwq
reviewed
Oct 24, 2022
src/libraries/System.Collections/src/System/Collections/Generic/PriorityQueue.cs
Show resolved
Hide resolved
krwq
reviewed
Oct 24, 2022
| // there at this point, as such an assignment would be redundant. | ||
|
|
||
| int currentSize = _size++; | ||
| int currentSize = _size; |
Member
There was a problem hiding this comment.
could MoveUpDefaultComparer/MoveUpCustomComparer throw? If so should you be doing _size + 1 here and _size = currentSize in the end of this method?
Member
Author
There was a problem hiding this comment.
No, it cannot. I could have moved it to the end of the method, but the Move* implementations currently require the size being up to date and I didn't want to change that invariant.
krwq
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #77212.