Skip to content

Detriplicate internal SingleProducerSingleConsumerQueue#76932

Merged
stephentoub merged 1 commit intodotnet:mainfrom
stephentoub:deduppcq
Oct 24, 2022
Merged

Detriplicate internal SingleProducerSingleConsumerQueue#76932
stephentoub merged 1 commit intodotnet:mainfrom
stephentoub:deduppcq

Conversation

@stephentoub
Copy link
Member

System.Private.CoreLib, System.Threading.Tasks.Dataflow, and System.Threading.Channels have all ended up with their own copy of SingleProducerSingleConsumerQueue and its associated helpers. This consolidates them down to a single shared copy.

There's no functional change here, just deleting duplicates and moving things around.

@ghost ghost assigned stephentoub Oct 12, 2022
System.Private.CoreLib, System.Threading.Tasks.Dataflow, and System.Threading.Channels have all ended up with their own copy of SingleProducerSingleConsumerQueue and its associated helpers.  This consolidates them down to a single shared copy.

There's no functional change here, just deleting duplicates and moving things around.
@ghost
Copy link

ghost commented Oct 12, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Private.CoreLib, System.Threading.Tasks.Dataflow, and System.Threading.Channels have all ended up with their own copy of SingleProducerSingleConsumerQueue and its associated helpers. This consolidates them down to a single shared copy.

There's no functional change here, just deleting duplicates and moving things around.

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Threading

Milestone: -

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephentoub stephentoub merged commit 70fb135 into dotnet:main Oct 24, 2022
@stephentoub stephentoub deleted the deduppcq branch October 24, 2022 19:39
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants