Skip to content

Move static members to another type - qualifies static member references in the moved members#80178

Merged
akhera99 merged 3 commits intodotnet:mainfrom
akhera99:dev/ankitakhera/move_static_members_bug
Sep 10, 2025
Merged

Move static members to another type - qualifies static member references in the moved members#80178
akhera99 merged 3 commits intodotnet:mainfrom
akhera99:dev/ankitakhera/move_static_members_bug

Conversation

@akhera99
Copy link
Member

@akhera99 akhera99 commented Sep 8, 2025

Fixes #79806

@akhera99 akhera99 marked this pull request as ready for review September 8, 2025 21:33
@akhera99 akhera99 requested a review from a team as a code owner September 8, 2025 21:33

foreach (var memberNode in members)
{
foreach (var identifierNode in memberNode.DescendantNodes().Where(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's intentional that you're only walking into the member nodes to update things? (i'm not saying this is incorrect, i'm genuinely just asking if thjat's intentional). If so, please doc why.

@akhera99 akhera99 merged commit 5ef3ca1 into dotnet:main Sep 10, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 10, 2025
@akhera99 akhera99 deleted the dev/ankitakhera/move_static_members_bug branch September 10, 2025 21:31
333fred added a commit to 333fred/roslyn that referenced this pull request Sep 11, 2025
* upstream/main: (233 commits)
  Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API (dotnet#80170)
  Fix error when hoisting a non-ref call (dotnet#80138)
  Ensure that refkinds are rewritten for complex methods (dotnet#79916)
  Revert
  Do not go through the workspace to access services
  DefiniteAssignmentPass.MarkFieldsUsed - avoid infinite recursion due to generic substitution (dotnet#80135)
  Reduce allocations in AnalyzerDriver.TryExecuteSymbolEndActions (dotnet#79855)
  RefSafetyAnalysis: Fix handling of nested deconstruction utilizing modern extensions (dotnet#80231)
  Extensions: adjust rewriting of anonymous type property symbols (dotnet#80211)
  Extensions: Move public APIs into INamedTypeSymbol (dotnet#80230)
  Extensions: improve error recovery in older language versions (dotnet#80206)
  Fall back to `dotnet exec` if apphost does not exist (dotnet#80153)
  Update dependencies from https://github.com/dotnet/dotnet build 282708 (dotnet#80228)
  Add a workaround for microsoft/vs-mef#620
  Revert "FailFast if the MEF composition is clearly broken"
  switch from windows combobox to visualstudio combobox (dotnet#80219)
  Update System.Text.Json in packages which use 4.12 Roslyn (dotnet#80197)
  add flags to unblock CI (dotnet#80222)
  Move static members to another type - qualifies static member references in the moved members (dotnet#80178)
  Fix broken link for C# 14 lambda parameter modifiers
  ...
@akhera99 akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move static members to another type... doesn't modify references to static members it doesn't move

3 participants