Skip to content

DefiniteAssignmentPass.MarkFieldsUsed - avoid infinite recursion due to generic substitution#80135

Merged
AlekseyTs merged 1 commit intodotnet:mainfrom
AlekseyTs:Issue79867
Sep 11, 2025
Merged

DefiniteAssignmentPass.MarkFieldsUsed - avoid infinite recursion due to generic substitution#80135
AlekseyTs merged 1 commit intodotnet:mainfrom
AlekseyTs:Issue79867

Conversation

@AlekseyTs
Copy link
Contributor

Fixes #79867.

@AlekseyTs AlekseyTs requested a review from a team as a code owner September 4, 2025 13:30
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For a second review of a tiny change

@AlekseyTs AlekseyTs requested a review from a team September 10, 2025 15:36
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For a second review of a tiny change

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For a second review of a tiny change that waits for review for about a week now.

#nullable enable
private void MarkFieldsUsed(TypeSymbol type)
{
type = type.OriginalDefinition;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth a comment.

@AlekseyTs AlekseyTs merged commit fa84199 into dotnet:main Sep 11, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 11, 2025
333fred added a commit to 333fred/roslyn that referenced this pull request Sep 11, 2025
* upstream/main: (233 commits)
  Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API (dotnet#80170)
  Fix error when hoisting a non-ref call (dotnet#80138)
  Ensure that refkinds are rewritten for complex methods (dotnet#79916)
  Revert
  Do not go through the workspace to access services
  DefiniteAssignmentPass.MarkFieldsUsed - avoid infinite recursion due to generic substitution (dotnet#80135)
  Reduce allocations in AnalyzerDriver.TryExecuteSymbolEndActions (dotnet#79855)
  RefSafetyAnalysis: Fix handling of nested deconstruction utilizing modern extensions (dotnet#80231)
  Extensions: adjust rewriting of anonymous type property symbols (dotnet#80211)
  Extensions: Move public APIs into INamedTypeSymbol (dotnet#80230)
  Extensions: improve error recovery in older language versions (dotnet#80206)
  Fall back to `dotnet exec` if apphost does not exist (dotnet#80153)
  Update dependencies from https://github.com/dotnet/dotnet build 282708 (dotnet#80228)
  Add a workaround for microsoft/vs-mef#620
  Revert "FailFast if the MEF composition is clearly broken"
  switch from windows combobox to visualstudio combobox (dotnet#80219)
  Update System.Text.Json in packages which use 4.12 Roslyn (dotnet#80197)
  add flags to unblock CI (dotnet#80222)
  Move static members to another type - qualifies static member references in the moved members (dotnet#80178)
  Fix broken link for C# 14 lambda parameter modifiers
  ...
@akhera99 akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StackOverflow during DefiniteAssignment

4 participants