Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API by jcouv · Pull Request #80170 · dotnet/roslyn

jcouv · 2025-09-08T07:55:56Z

Public API proposal: #80167
Addresses parts of public API follow-ups for extensions: #78957
Relates to test plan #76130

TryGetCorrespondingExtensionImplementationMethod API

CyrusNajmabadi · 2025-09-08T08:28:29Z

src/Workspaces/CSharpTest/CodeGeneration/SyntaxGeneratorTests.cs

+        }
+    }
+}
+""");


indent. we try not to do raw strings this way in the IDE. #Resolved

CyrusNajmabadi · 2025-09-08T08:29:46Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs

+        static IEnumerable<ISymbol> getMembers(INamedTypeSymbol type)
+        {
+            var members = type.GetMembers();
+            PooledHashSet<IMethodSymbol>? implementationsToHide = null;


no need to make this null to begin with. just do:

using var _ = PooledHashSet<IMethodSymbol>.GetInstance(out var implementationsToHide); #Resolved

CyrusNajmabadi · 2025-09-08T08:29:56Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs

+                        if (extensionMember is IMethodSymbol shadows &&
+                            shadows.OriginalDefinition.TryGetCorrespondingExtensionImplementationMethod() is { } toShadow)
+                        {
+                            implementationsToHide ??= PooledHashSet<IMethodSymbol>.GetInstance();


Suggested change

implementationsToHide ??= PooledHashSet<IMethodSymbol>.GetInstance();

``` #Resolved

CyrusNajmabadi · 2025-09-08T08:30:32Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs

+                return members;
+            }
+
+            var result = ArrayBuilder<ISymbol>.GetInstance();


Suggested change

var result = ArrayBuilder<ISymbol>.GetInstance();

using var _2 = ArrayBuilder<ISymbol>.GetInstance(out var result);

``` #Resolved

CyrusNajmabadi · 2025-09-08T08:30:43Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs

+            implementationsToHide.Free();
+            return result.ToImmutableAndFree();


Suggested change

implementationsToHide.Free();

return result.ToImmutableAndFree();

return result.ToImmutableAndClear();

``` #Resolved

CyrusNajmabadi · 2025-09-08T08:30:55Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs


        throw new ArgumentException("Symbol cannot be converted to a declaration");
+
+        static IEnumerable<ISymbol> getMembers(INamedTypeSymbol type)


Suggested change

static IEnumerable<ISymbol> getMembers(INamedTypeSymbol type)

static IEnumerable<ISymbol> GetMembers(INamedTypeSymbol type)

``` #Resolved

IDE uses camelCase to indicate an allocated delegate. and PascalCase to indicate a normal called function/method.

CyrusNajmabadi · 2025-09-08T08:31:35Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs

+                if (member is IMethodSymbol method)
+                {
+                    // Hide implementation methods
+                    if (!implementationsToHide.Remove(method.OriginalDefinition))


do you need to remove? or just check containment? #Resolved

CyrusNajmabadi · 2025-09-08T09:36:19Z

src/Compilers/CSharp/Portable/Symbols/PublicModel/MethodSymbol.cs

+#nullable enable
+        IMethodSymbol? IMethodSymbol.TryGetCorrespondingExtensionImplementationMethod()
+        {
+            if (!_underlying.IsDefinition || !_underlying.GetIsNewExtensionMember())


curious why the need for the .IsDefinition check. Thanks! #Resolved

See assertion in NamedTypeSymbol.TryGetCorrespondingExtensionImplementationMethod that we use below

CyrusNajmabadi · 2025-09-08T09:37:24Z

src/Compilers/CSharp/Test/Syntax/Syntax/SyntaxNormalizerTests.cs

+  {
+  }
+}
+""");


i'd prefer if you kept this consistent with the test above (for indentation) :)

#Resolved

consider adding test without generic type parameters on the extension as well.

CyrusNajmabadi · 2025-09-08T09:38:24Z

src/Compilers/Core/Portable/Symbols/IMethodSymbol.cs

        bool IsIterator { get; }
+
+        /// <summary>
+        /// For a method definition in an extension block, returns the corresponding implementation method if one exists.


consider an example. i'm somewhat familiar with this space. but even so, knowing what the 'impl method' is vs the extension def isn't too clear to me. #Resolved

CyrusNajmabadi · 2025-09-08T09:40:30Z

src/Compilers/Core/Portable/Symbols/IMethodSymbol.cs

+        /// For a method definition in an extension block, returns the corresponding implementation method if one exists.
+        /// Returns null otherwise.
+        /// </summary>
+        IMethodSymbol? TryGetCorrespondingExtensionImplementationMethod();


nit: i presume this went through API review. i do find the name somewhat strange. we don't really use 'Try' in the names of our ISymbol methods (afaict). We sometimes use 'Find' like FindImplementationForInterfaceMember. or we just have things like IMethodSymbol? OverriddenMethod.

So, perhaps this should just be CorrespondingExtensionImplementationMethod? or FindCorrespondingExtensionImplementationMethod? #Resolved

Link for API review in OP. I'm hoping we'll discuss tomorrow.
I'm sure we'll discuss naming options. Maybe AssociatedExtensionImplementation

SGTM :) I'll ignre the naming for this review then.

jjonescz · 2025-09-09T10:21:02Z

src/Compilers/CSharp/Portable/Syntax/SyntaxNormalizer.cs

            }

-            if (IsKeyword(token.Kind()))
+            if (IsKeyword(token.Kind()) && !token.IsKind(SyntaxKind.ExtensionKeyword))


Consider moving the IsKind check to the if below (which has all the other IsKind checks) for consistency #ByDesign

I see there is a check on token embedded in logic below, but I prefer to keep the checks on token here and the checks on next below. I find that rough structure helpful

jjonescz · 2025-09-09T11:46:33Z

src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs

+        var model = comp.GetSemanticModel(tree);
+        var memberAccess = GetSyntax<MemberAccessExpressionSyntax>(tree, "42.M");
+        var method = (IMethodSymbol)model.GetSymbolInfo(memberAccess).Symbol;
+        Assert.Null(method.AssociatedExtensionImplementation);


Consider verifying method.OriginalDefinition.AssociatedExtensionImplementation. #Resolved

jjonescz · 2025-09-09T11:49:33Z

src/Compilers/Core/Portable/Symbols/IMethodSymbol.cs

+        /// For a method definition in an extension block, returns the corresponding implementation method if one exists.
+        /// Returns null otherwise.
+        /// 
+        /// For exampe, considering:


Suggested change

/// For exampe, considering:

/// For example, considering:

``` #Resolved

jjonescz · 2025-09-09T11:50:12Z

src/Compilers/Core/Portable/Symbols/IMethodSymbol.cs

+        /// Returns null otherwise.
+        /// 
+        /// For exampe, considering:
+        /// ```


In doc comments, consider using <code> and <c> instead of markdown syntax. #Resolved

jjonescz · 2025-09-09T11:52:00Z

src/Workspaces/CSharp/Portable/CodeGeneration/CSharpSyntaxGenerator.cs

+        IEnumerable<SyntaxNode>? typeParameters,
+        IEnumerable<SyntaxNode> members)
+    {
+        SyntaxList<MemberDeclarationSyntax> extensionMembers = [.. members.Select(m => m as MemberDeclarationSyntax).WhereNotNull()];


nit:

Suggested change

SyntaxList<MemberDeclarationSyntax> extensionMembers = [.. members.Select(m => m as MemberDeclarationSyntax).WhereNotNull()];

SyntaxList<MemberDeclarationSyntax> extensionMembers = [.. members.OfType<MemberDeclarationSyntax>().WhereNotNull()];

``` #Resolved

jjonescz · 2025-09-09T11:53:14Z

src/Workspaces/CSharpTest/CodeGeneration/SyntaxGeneratorTests.cs

+        var compilation = Compile("""
+            public static class E
+            {
+                extension<T>(int)


Are generic constraints going to work? #Resolved

jjonescz · 2025-09-09T11:53:55Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs


        throw new ArgumentException("Symbol cannot be converted to a declaration");
+
+        static IEnumerable<ISymbol> GetMembersMinusExtensionImplementations(INamedTypeSymbol type)


nit: "except" seems like a better term for this than "minus" #Resolved

jcouv · 2025-09-09T17:19:34Z

~~Marked as draft as API review decided to move an number of APIs into INamedTypeSymbol. I'll do that as part of #80164~~

jjonescz · 2025-09-09T17:02:06Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs

+                {
+                    foreach (var extensionMember in nested.GetMembers())
+                    {
+                        if (extensionMember is IMethodSymbol { OriginalDefinition.AssociatedExtensionImplementation: { } toShadow })


In API review, you said that the SyntaxGenerator cannot use IsImplicitlyDeclared because the SyntaxGenerator can sometimes emit implicitly declared symbols for ApiDiff. Can you provide an example of that? It seems to me that ApiDiff should always work just with the user-declared APIs since the implicitly declared symbols are fully determined by what the user declares. #Resolved

What I said is that SourceGenerator needs to work with both source and metadata symbols. But the strategy of using IsImplicitlyDeclared to filter out implementation methods would not work in metadata scenario.

I didn't investigate in details how GenAPI/ApiDiff deals with hiding certain members. I'm not sure if it needs to.
But I did observe that it has custom logic on top of SourceGenerator: https://github.com/dotnet/sdk/blob/main/src/Compatibility/GenAPI/Microsoft.DotNet.GenAPI/SyntaxGeneratorExtensions.cs

Regardless, I think from the SourceGenerator perspective, hiding the implementation methods seems the right thing to do and it needs to deal with metadata symbols.

jjonescz · 2025-09-11T16:08:28Z

src/Workspaces/CSharp/Portable/CodeGeneration/CSharpSyntaxGenerator.cs

+
+        return SyntaxFactory.ExtensionBlockDeclaration(attributeLists: default, modifiers: default, ExtensionKeyword,
+            typeParameterList, parameterList: AsParameterList([extensionParameter]),
+            constraintClauses: default, OpenBraceToken, extensionMembers, CloseBraceToken, default);


constraintClauses: default

We don't need to be passing any constraint clauses here? #Resolved

No, we first generate syntax without constraints and then add them.
See ClassDeclaration factory method for another example illustrating how we don't initially pass constraints.
Then you can see how WithTypeParametersAndConstraints is used to amend the generated syntax
I'm not sure why things were structured this way to start with...

I think it was because we had a circularity. to have to generate contraints, we needed tyep parameters. but to have type parameters, we needed the symbol. in a fully immutable model, this was challenging. So, instead, we do it two phase. create things like the method/type with the type parameters. then add constreaints.

but this is lost to the annals of time for me now :)

jcouv · 2025-09-11T17:08:55Z

@CyrusNajmabadi Any additional comments? Let me know if you are also covering the second compiler review, or only the IDE portion.

CyrusNajmabadi · 2025-09-11T17:27:29Z

Looking!

CyrusNajmabadi · 2025-09-11T17:29:18Z

src/Workspaces/CSharpTest/CodeGeneration/SyntaxGeneratorTests.cs

+                {
+                }
+            }
+            """);


i might add a test with a static extension method.

Sorry, I'd missed this feedback. Addressed in #80249

CyrusNajmabadi · 2025-09-11T17:30:28Z

src/Workspaces/Core/Portable/Editing/SyntaxGenerator.cs

+                if (member is IMethodSymbol method)
+                {
+                    // Hide implementation methods
+                    if (!implementationsToHide.Contains(method.OriginalDefinition))
+                    {
+                        result.Add(member);
+                    }
+                }
+                else
+                {
+                    result.Add(member);
+                }


Suggested change

if (member is IMethodSymbol method)

{

// Hide implementation methods

if (!implementationsToHide.Contains(method.OriginalDefinition))

{

result.Add(member);

}

}

else

{

result.Add(member);

}

// Hide implementation methods

if (member is not IMethodSymbol method ||

!implementationsToHide.Contains(method.OriginalDefinition))

{

result.Add(member);

}

CyrusNajmabadi

Signing off on both IDE and compiler side.

* upstream/main: (233 commits) Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API (dotnet#80170) Fix error when hoisting a non-ref call (dotnet#80138) Ensure that refkinds are rewritten for complex methods (dotnet#79916) Revert Do not go through the workspace to access services DefiniteAssignmentPass.MarkFieldsUsed - avoid infinite recursion due to generic substitution (dotnet#80135) Reduce allocations in AnalyzerDriver.TryExecuteSymbolEndActions (dotnet#79855) RefSafetyAnalysis: Fix handling of nested deconstruction utilizing modern extensions (dotnet#80231) Extensions: adjust rewriting of anonymous type property symbols (dotnet#80211) Extensions: Move public APIs into INamedTypeSymbol (dotnet#80230) Extensions: improve error recovery in older language versions (dotnet#80206) Fall back to `dotnet exec` if apphost does not exist (dotnet#80153) Update dependencies from https://github.com/dotnet/dotnet build 282708 (dotnet#80228) Add a workaround for microsoft/vs-mef#620 Revert "FailFast if the MEF composition is clearly broken" switch from windows combobox to visualstudio combobox (dotnet#80219) Update System.Text.Json in packages which use 4.12 Roslyn (dotnet#80197) add flags to unblock CI (dotnet#80222) Move static members to another type - qualifies static member references in the moved members (dotnet#80178) Fix broken link for C# 14 lambda parameter modifiers ...

* upstream/main: (201 commits) Handle extension blocks in CLS compliance checker (#80251) Fix Simplify Simplify Simplify Simplify Simplify Add doc for GetInferredNullableAnnotation (#80245) Rename files to match type within Implement ref local hoisting in runtime async. Closes #79763. Pull ref initialization hoisting into a reusable class for use in runtime async REvert Break cycle for lambda using field keyword with inferred return type (#79995) Simplify tests Simplify Fixup New extension Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API (#80170) In process Support 'add using' for modern extension methods ...

* upstream/main: (1725 commits) Handle extension blocks in CLS compliance checker (dotnet#80251) Fix Simplify Simplify Simplify Simplify Simplify Add doc for GetInferredNullableAnnotation (dotnet#80245) Rename files to match type within Implement ref local hoisting in runtime async. Closes dotnet#79763. Pull ref initialization hoisting into a reusable class for use in runtime async REvert Break cycle for lambda using field keyword with inferred return type (dotnet#79995) Simplify tests Simplify Fixup New extension Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API (dotnet#80170) In process Support 'add using' for modern extension methods ...

* upstream/main: (131 commits) Handle extension blocks in CLS compliance checker (dotnet#80251) Fix Simplify Simplify Simplify Simplify Simplify Add doc for GetInferredNullableAnnotation (dotnet#80245) Rename files to match type within Implement ref local hoisting in runtime async. Closes dotnet#79763. Pull ref initialization hoisting into a reusable class for use in runtime async REvert Break cycle for lambda using field keyword with inferred return type (dotnet#79995) Simplify tests Simplify Fixup New extension Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API (dotnet#80170) In process Support 'add using' for modern extension methods ...

jcouv self-assigned this Sep 8, 2025

jcouv added Area-Compilers Feature - Extension Everything The extension everything feature labels Sep 8, 2025

dotnet-policy-service bot added VSCode Needs API Review Needs to be reviewed by the API review council labels Sep 8, 2025

jcouv added the Area-IDE label Sep 8, 2025

Extensions: add SyntaxGenerator support and

9ec4c31

TryGetCorrespondingExtensionImplementationMethod API

jcouv force-pushed the extensions-generator branch from 66fbb77 to 9ec4c31 Compare September 8, 2025 08:24

CyrusNajmabadi reviewed Sep 8, 2025

View reviewed changes

jcouv mentioned this pull request Sep 8, 2025

Extensions: public API follow-ups #78957

Open

14 tasks

Address feedback

f7efc5b

jcouv requested a review from CyrusNajmabadi September 8, 2025 09:35

jcouv marked this pull request as ready for review September 8, 2025 09:35

jcouv requested review from a team as code owners September 8, 2025 09:35

CyrusNajmabadi reviewed Sep 8, 2025

View reviewed changes

Julien Couvreur added 2 commits September 8, 2025 03:50

Address feedback

f8171b1

Tweak and rename

580b1d1

jcouv changed the title ~~Extensions: add SyntaxGenerator support and TryGetCorrespondingExtensionImplementationMethod API~~ Extensions: add SyntaxGenerator support and AssociatedExtensionImplementation API Sep 8, 2025

Update SemanticSearch file

a8158bc

jcouv requested review from AlekseyTs and jjonescz September 8, 2025 20:24

jjonescz reviewed Sep 9, 2025

View reviewed changes

Julien Couvreur added 2 commits September 9, 2025 09:28

Merge remote-tracking branch 'dotnet/main' into extensions-generator

7130b30

Address feedback

1bc6ae8

jcouv marked this pull request as draft September 9, 2025 17:18

jjonescz reviewed Sep 9, 2025

View reviewed changes

jcouv marked this pull request as ready for review September 11, 2025 13:29

jcouv requested review from CyrusNajmabadi and jjonescz September 11, 2025 13:31

jjonescz reviewed Sep 11, 2025

View reviewed changes

jjonescz approved these changes Sep 11, 2025

View reviewed changes

CyrusNajmabadi reviewed Sep 11, 2025

View reviewed changes

CyrusNajmabadi approved these changes Sep 11, 2025

View reviewed changes

jcouv merged commit ea9d5bf into dotnet:main Sep 11, 2025
28 checks passed

jcouv deleted the extensions-generator branch September 11, 2025 17:36

dotnet-policy-service bot added this to the Next milestone Sep 11, 2025

jcouv mentioned this pull request Sep 12, 2025

Address missed feedback on SyntaxGenerator #80249

Merged

akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025

	implementationsToHide ??= PooledHashSet<IMethodSymbol>.GetInstance();
	``` #Resolved

	var result = ArrayBuilder<ISymbol>.GetInstance();
	using var _2 = ArrayBuilder<ISymbol>.GetInstance(out var result);
	``` #Resolved

		implementationsToHide.Free();
		return result.ToImmutableAndFree();


		throw new ArgumentException("Symbol cannot be converted to a declaration");

		static IEnumerable<ISymbol> getMembers(INamedTypeSymbol type)

	/// For exampe, considering:
	/// For example, considering:
	``` #Resolved

	SyntaxList<MemberDeclarationSyntax> extensionMembers = [.. members.Select(m => m as MemberDeclarationSyntax).WhereNotNull()];
	SyntaxList<MemberDeclarationSyntax> extensionMembers = [.. members.OfType<MemberDeclarationSyntax>().WhereNotNull()];
	``` #Resolved


		throw new ArgumentException("Symbol cannot be converted to a declaration");

		static IEnumerable<ISymbol> GetMembersMinusExtensionImplementations(INamedTypeSymbol type)

Conversation

jcouv commented Sep 8, 2025

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CyrusNajmabadi Sep 8, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjonescz Sep 9, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjonescz Sep 9, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjonescz Sep 9, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjonescz Sep 9, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjonescz Sep 9, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjonescz Sep 9, 2025 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

CyrusNajmabadi Sep 8, 2025 •

edited by jcouv

Loading

jjonescz Sep 9, 2025 •

edited by jcouv

Loading

jjonescz Sep 9, 2025 •

edited by jcouv

Loading

jjonescz Sep 9, 2025 •

edited by jcouv

Loading

jjonescz Sep 9, 2025 •

edited by jcouv

Loading

jjonescz Sep 9, 2025 •

edited by jcouv

Loading

jjonescz Sep 9, 2025 •

edited by jcouv

Loading

jjonescz Sep 9, 2025 •

edited by jcouv

Loading

jcouv commented Sep 9, 2025 •

edited

Loading

jjonescz Sep 9, 2025 •

edited by jcouv

Loading

jjonescz Sep 11, 2025 •

edited by jcouv

Loading