Skip to content

Merge main into features/dictionary-expressions#76889

Merged
cston merged 2630 commits intodotnet:features/dictionary-expressionsfrom
cston:update-dictionary-expressions
Jan 23, 2025
Merged

Merge main into features/dictionary-expressions#76889
cston merged 2630 commits intodotnet:features/dictionary-expressionsfrom
cston:update-dictionary-expressions

Conversation

@cston
Copy link
Contributor

@cston cston commented Jan 23, 2025

No description provided.

jjonescz and others added 30 commits January 15, 2025 10:07
* Prefer ReadOnlySpan over Span as better conversion target

* Test identity element conversions

* Exclude span types from the second rule

Addresses LDM feedback.

* Handle Span vs non-span type

* Extend tests
* Add feature flag for emitting string literals into data section as UTF8

* Address feedback

* Simplify some APIs

* Lift well known type member check

* Obtain the string type lazily

* Consolidate static constructor implementations

* Encapsulate IL emit of BytesToStringHelper

* Extract NestedTypeDefinition

* Share ParameterDefinitionBase

* Add more doc comments

* Remove unnecessary `using`s

* Avoid passing text and data together

* Avoid immutable array allocation

* Remove ITokenDeferral and SystemStringType passing

* Simplify parameter definition

* Cache threshold

* Simplify code

* Re-add Opt suffix

* Remove an unnecessary using

* Extend tests

* Improve tests

* Improve code
* Copy feature spec

* Add "literal" to the feature flag

* Add more details

* Convert indentation to spaces

* Rename feature flag

* Improve

* Improve

* Update an implementation detail

* Improve

* Update after feature review

* Make the shared helper private

* Do not detect XXH128 collisions

* Clarify feature flag values

* Improve wording

* Remove note
jasonmalinowski and others added 14 commits January 22, 2025 15:34
…#76747)

Without this, Microsoft.CodeAnalysis.Workspaces.MSBuild.dll itself is
deployed, but will fail to work since it can't find any build hosts
deployed alongside the DLL.

Fixes dotnet#73854
…6866)

Current guess is that this is the cause of the rps/speedometer ngen
failures.
Also the signing variable override doesn't appear to work (variable
already defined in pipeline UI gets overriden to empty. and the msbuild
condition I think should be DotNetSignType)

This reverts commit 2eca5b2, reversing
changes made to fe3a243.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2317372

Presumably something changed in Roslyn where encoding can be null now?
🤷‍♂️
…76876)

Enables format on type when the trigger character is a newline. Removes
text changes that contain the cursor as we do not want to remove the
indentation.



https://github.com/user-attachments/assets/962f8229-f41b-4632-a8e9-b7660575e448



Resolves dotnet/vscode-csharp#6834
…didateSet (dotnet#76835)

* Reduce work in ConversionsBase.AddUserDefinedConversionsToExplicitCandidateSet

The ArrayBuilder usage in this method is showing up slightly in speedometer CPU profiles (0.1%) but more heavily in local profiles I've taken using a much larger version of the file than what the speedometer tests use (2.6%)

This method is called quite often and the (isExplicit && isChecked) check seems to not hit very often (specifically, never in my testing of opening/simple editing of the file). The usage of the pool and populating the array builder aren't necessary unless that case is hit, so I've reshuffled the code around a bit to avoid that.
* Add feature status of Partial Events and Constructors

* Link champion issue
The issue mentioned in the comment has been fixed since almost nine years ago.
Verified this produces a dll with data embedded
```
PS C:\Users\dabarbet\Downloads\net472> .\ibcmerge.exe -dxml -mi C:\Users\dabarbet\Downloads\officual_build_vsix\new_official_build\Microsoft.CodeAnalysis.LanguageServer.Protocol.dll
Reading IBC resource from file: C:\Users\dabarbet\Downloads\officual_build_vsix\new_official_build\Microsoft.CodeAnalysis.LanguageServer.Protocol.dll
Xml output file: C:\Users\dabarbet\Downloads\officual_build_vsix\new_official_build\Microsoft.CodeAnalysis.LanguageServer.Protocol.ibc.xml
```


![image](https://github.com/user-attachments/assets/e67304b5-2f07-4a5d-b7ab-9160b171440b)
@cston cston requested review from a team as code owners January 23, 2025 19:27
@dotnet-policy-service dotnet-policy-service bot added VSCode Needs UX Triage Needs API Review Needs to be reviewed by the API review council labels Jan 23, 2025
@dotnet-policy-service
Copy link
Contributor

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 23, 2025
@cston cston merged commit 004c6ca into dotnet:features/dictionary-expressions Jan 23, 2025
28 checks passed
@cston cston deleted the update-dictionary-expressions branch January 24, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure Needs API Review Needs to be reviewed by the API review council Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.