Prefer ReadOnlySpan over Span as better conversion target#76300
Merged
jjonescz merged 5 commits intodotnet:mainfrom Jan 15, 2025
Merged
Prefer ReadOnlySpan over Span as better conversion target#76300jjonescz merged 5 commits intodotnet:mainfrom
jjonescz merged 5 commits intodotnet:mainfrom
Conversation
cston
reviewed
Dec 8, 2024
cston
approved these changes
Dec 9, 2024
Addresses LDM feedback.
cston
reviewed
Dec 10, 2024
cston
reviewed
Dec 10, 2024
src/Compilers/CSharp/Portable/Binder/Semantics/OverloadResolution/OverloadResolution.cs
Show resolved
Hide resolved
cston
reviewed
Dec 10, 2024
src/Compilers/CSharp/Portable/Binder/Semantics/OverloadResolution/OverloadResolution.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Dec 11, 2024
Member
Author
|
@333fred @dotnet/roslyn-compiler for a second review, thanks |
Member
Author
|
@333fred for the second review, thanks (would like to merge this soon so it goes into 17.13 to overwrite the previous change which is there) |
Member
|
@333fred PTAL |
333fred
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan: #73445
Follow up on #75853 from LDM 2024-12-04.
Speclet change: dotnet/csharplang#8779