Fix new document formatting#76736
Merged
davidwengier merged 2 commits intodotnet:mainfrom Jan 23, 2025
Merged
Conversation
CyrusNajmabadi
approved these changes
Jan 13, 2025
Member
Author
|
Oh cool, the test failure is real, so presumably this change broke things: https://github.com/dotnet/roslyn/pull/74623/files#r1865988171 @jasonmalinowski @CyrusNajmabadi do you want a follow up issue to re-look at the DocumentState change? |
Contributor
|
@jasonmalinowski can yuo ptal :) |
CyrusNajmabadi
approved these changes
Jan 14, 2025
Member
Author
|
Running in to this in Razor, and it's been annoying me, so I'm going to merge this fix. If there is follow up, I'm very unlikely to be the right person to do the work anyway, so it wouldn't be in this PR regardless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2317372
Presumably something changed in Roslyn where encoding can be null now? 🤷♂️