Fixup 'add import on paste' to respect import ordering and grouping#76761
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Jan 15, 2025
Merged
Fixup 'add import on paste' to respect import ordering and grouping#76761CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Jan 15, 2025
|
|
||
| var expected = """ | ||
| using A; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
desirable change.
CyrusNajmabadi
commented
Jan 15, 2025
| namespace Microsoft.CodeAnalysis.AddMissingImports; | ||
|
|
||
| internal sealed class AddMissingImportsAnalysisResult( | ||
| ImmutableArray<AddImportFixData> addImportFixData) |
Contributor
Author
There was a problem hiding this comment.
got rid of this wrapper type as it serves no purpose.
akhera99
approved these changes
Jan 15, 2025
This was referenced Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51844
Fixes #68632