Skip to content

Avoid using constants for large string literals#74305

Merged
jjonescz merged 1 commit intodotnet:mainfrom
jjonescz:TooManyStrings
Jul 9, 2024
Merged

Avoid using constants for large string literals#74305
jjonescz merged 1 commit intodotnet:mainfrom
jjonescz:TooManyStrings

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented Jul 9, 2024

Follow up on #74281. Fixes:

CSC : error CS8103: Combined length of user strings used by the program exceeds allowed limit. Try to decrease use of string literals. [D:\a_work\1\s\src\Compilers\CSharp\Test\Emit2\Microsoft.CodeAnalysis.CSharp.Emit2.UnitTests.csproj::TargetFramework=net9.0]

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 9, 2024
@jjonescz jjonescz marked this pull request as ready for review July 9, 2024 12:29
@jjonescz jjonescz requested a review from a team as a code owner July 9, 2024 12:29
@jjonescz jjonescz enabled auto-merge (squash) July 9, 2024 12:29
@AlekseyTs
Copy link
Contributor

I think it would be good to check for other constant fields that our unit-test projects can reference from our shared test libraries.

@jjonescz
Copy link
Member Author

jjonescz commented Jul 9, 2024

I think it would be good to check for other constant fields that our unit-test projects can reference from our shared test libraries.

#74307

@jjonescz jjonescz merged commit b3a18bb into dotnet:main Jul 9, 2024
@jjonescz jjonescz deleted the TooManyStrings branch July 9, 2024 13:52
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 9, 2024
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 9, 2024
…solution-priority

* upstream/main: (184 commits)
  Disable BuildWithNetFrameworkHostedCompiler (dotnet#74299)
  Avoid using constants for large string literals (dotnet#74305)
  Adjust lowering of a string interpolation in an expression lambda to not use expanded non-array `params` collection in Format/Create calls. (dotnet#74274)
  Consolidate test Span sources (dotnet#74281)
  Allow Document.FilePath to be set to null (dotnet#74290)
  Update Directory.Build.rsp
  Remove fallback options from IdeAnalyzerOptions (dotnet#74235)
  Fix msbuild issue
  Improve parser recovery around nullable types in patterns (dotnet#72805)
  Syntax formatting options (dotnet#74223)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2490585 (dotnet#74287)
  fix (dotnet#74276)
  Remove more
  fix (dotnet#74237)
  Fix scenario where lightbulbs weren't being displayed
  Reduce closures allocated during invocation of CapturedSymbolReplacement.Replacement (dotnet#74258)
  Reduce allocations in SymbolDeclaredCompilationEvent (dotnet#74250)
  remove type that now serves no purpose
  Remove uncalled method
  Remove more unused code
  ...
jjonescz added a commit to jjonescz/roslyn that referenced this pull request Jul 11, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants