Skip to content

Consolidate test Span sources#74281

Merged
jjonescz merged 1 commit intodotnet:mainfrom
jjonescz:SpanTestSources
Jul 9, 2024
Merged

Consolidate test Span sources#74281
jjonescz merged 1 commit intodotnet:mainfrom
jjonescz:SpanTestSources

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented Jul 8, 2024

There were two definitions of Span/ReadOnlySpan used across tests, only slightly different. This PR merges them into one.

Useful for first-class Span tests. Extracted this refactoring to a separate PR as it feels orthogonal to the feature.

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 8, 2024
@jjonescz jjonescz marked this pull request as ready for review July 8, 2024 14:15
@jjonescz jjonescz requested a review from a team as a code owner July 8, 2024 14:15
@jjonescz jjonescz requested review from 333fred and cston July 8, 2024 14:16
@jjonescz jjonescz merged commit 7866265 into dotnet:main Jul 9, 2024
@jjonescz jjonescz deleted the SpanTestSources branch July 9, 2024 06:57
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 9, 2024
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 9, 2024
…solution-priority

* upstream/main: (184 commits)
  Disable BuildWithNetFrameworkHostedCompiler (dotnet#74299)
  Avoid using constants for large string literals (dotnet#74305)
  Adjust lowering of a string interpolation in an expression lambda to not use expanded non-array `params` collection in Format/Create calls. (dotnet#74274)
  Consolidate test Span sources (dotnet#74281)
  Allow Document.FilePath to be set to null (dotnet#74290)
  Update Directory.Build.rsp
  Remove fallback options from IdeAnalyzerOptions (dotnet#74235)
  Fix msbuild issue
  Improve parser recovery around nullable types in patterns (dotnet#72805)
  Syntax formatting options (dotnet#74223)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2490585 (dotnet#74287)
  fix (dotnet#74276)
  Remove more
  fix (dotnet#74237)
  Fix scenario where lightbulbs weren't being displayed
  Reduce closures allocated during invocation of CapturedSymbolReplacement.Replacement (dotnet#74258)
  Reduce allocations in SymbolDeclaredCompilationEvent (dotnet#74250)
  remove type that now serves no purpose
  Remove uncalled method
  Remove more unused code
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants