Skip to content

Adjust lowering of a string interpolation in an expression lambda to not use expanded non-array params collection in Format/Create calls.#74274

Merged
AlekseyTs merged 1 commit intodotnet:mainfrom
AlekseyTs:Issue74163
Jul 9, 2024

Conversation

@AlekseyTs
Copy link
Contributor

Fixes #74163.

…not use expanded non-array `params` collection in Format/Create calls.

Fixes dotnet#74163.
@AlekseyTs AlekseyTs requested review from 333fred and RikkiGibson July 5, 2024 15:53
@AlekseyTs AlekseyTs requested a review from a team as a code owner July 5, 2024 15:53
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 5, 2024
@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review

@RikkiGibson RikkiGibson self-assigned this Jul 8, 2024
@AlekseyTs AlekseyTs merged commit 2e87378 into dotnet:main Jul 9, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 9, 2024
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 9, 2024
…solution-priority

* upstream/main: (184 commits)
  Disable BuildWithNetFrameworkHostedCompiler (dotnet#74299)
  Avoid using constants for large string literals (dotnet#74305)
  Adjust lowering of a string interpolation in an expression lambda to not use expanded non-array `params` collection in Format/Create calls. (dotnet#74274)
  Consolidate test Span sources (dotnet#74281)
  Allow Document.FilePath to be set to null (dotnet#74290)
  Update Directory.Build.rsp
  Remove fallback options from IdeAnalyzerOptions (dotnet#74235)
  Fix msbuild issue
  Improve parser recovery around nullable types in patterns (dotnet#72805)
  Syntax formatting options (dotnet#74223)
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2490585 (dotnet#74287)
  fix (dotnet#74276)
  Remove more
  fix (dotnet#74237)
  Fix scenario where lightbulbs weren't being displayed
  Reduce closures allocated during invocation of CapturedSymbolReplacement.Replacement (dotnet#74258)
  Reduce allocations in SymbolDeclaredCompilationEvent (dotnet#74250)
  remove type that now serves no purpose
  Remove uncalled method
  Remove more unused code
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - ParamsCollections untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET 9 Preview.5, Preview.6, Preview.7 C# compiler crashes on LINQ expression with string interpolation

3 participants