Skip to content

Correctly set the TemplateSelector of inheritance margin.#60899

Merged
Cosifne merged 1 commit intodotnet:mainfrom
Cosifne:dev/shech/CorrectDeclareResources
Apr 25, 2022
Merged

Correctly set the TemplateSelector of inheritance margin.#60899
Cosifne merged 1 commit intodotnet:mainfrom
Cosifne:dev/shech/CorrectDeclareResources

Conversation

@Cosifne
Copy link
Copy Markdown
Member

@Cosifne Cosifne commented Apr 22, 2022

Fix #60894
After this there is no problem when try to expand multiple members
image

The reason is static resource must be declared first and then use : (

I think this is introduced back in this PR #56471

@Cosifne Cosifne requested a review from a team as a code owner April 22, 2022 00:55
@Cosifne Cosifne requested a review from CyrusNajmabadi April 22, 2022 00:55
@Cosifne
Copy link
Copy Markdown
Member Author

Cosifne commented Apr 22, 2022

Hi Sam, @sharwell
Do you know how to write an integration test for the glyphs in editor margin so that we could prevent such things happen?
Currently because there is no command linked to the inheritance margin glyphs, so I can't find a good way to expand it in the integration test.
Is there a good way to simulate mouse click event for such case?

@sharwell
Copy link
Copy Markdown
Contributor

Yes, set a meeting and I'll go over the necessary setup. There aren't any tests today that interact directly with the mouse, but I have other examples.

@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Apr 22, 2022
@Cosifne Cosifne merged commit ffd5872 into dotnet:main Apr 25, 2022
@ghost ghost added this to the Next milestone Apr 25, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
333fred added a commit that referenced this pull request Apr 26, 2022
…ures/semi-auto-props

* upstream/main: (266 commits)
  Pass fallback options (#60803)
  Rename `CodeStyleHostLanguageServices.cs.cs` to `CodeStyleHostLanguageServices.cs` (#60955)
  Allow VSMac to access LSP options (#60943)
  Add configs for 17.3 branch and update main version (#60942)
  Restore nugetKind config to publish data
  Remove unnecessary publish data config
  Remove non-servicing 15.x publish config
  Let 'arcade' packageFeeds imply all feeds are 'arcade'
  Remove non-servicing branches from our PublishData
  Handle unexpected keyword rather than identifier for lambda parameter name (#60825)
  Correctly return E_NOTIMPL when asked for file code models for non-source
  Move the resources to top (#60899)
  Add back deprecated packages to arcade publishing config.
  Simplify
  Rename parameter
  Simplify visibility logic in tagger
  Simplify visibility logic in tagger
  Try out some fixes
  Update StructConstructorTests.cs
  Use more descriptive variable name
  ...
333fred added a commit that referenced this pull request Apr 26, 2022
…ures/required-members

* upstream/main: (156 commits)
  Pass fallback options (#60803)
  Rename `CodeStyleHostLanguageServices.cs.cs` to `CodeStyleHostLanguageServices.cs` (#60955)
  Allow VSMac to access LSP options (#60943)
  Add configs for 17.3 branch and update main version (#60942)
  Restore nugetKind config to publish data
  Remove unnecessary publish data config
  Remove non-servicing 15.x publish config
  Let 'arcade' packageFeeds imply all feeds are 'arcade'
  Remove non-servicing branches from our PublishData
  Handle unexpected keyword rather than identifier for lambda parameter name (#60825)
  Correctly return E_NOTIMPL when asked for file code models for non-source
  Move the resources to top (#60899)
  Add back deprecated packages to arcade publishing config.
  Simplify
  Rename parameter
  Simplify visibility logic in tagger
  Simplify visibility logic in tagger
  Try out some fixes
  Update StructConstructorTests.cs
  Use more descriptive variable name
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Apr 27, 2022
…o forbid-new

* upstream/features/required-members: (156 commits)
  Pass fallback options (dotnet#60803)
  Rename `CodeStyleHostLanguageServices.cs.cs` to `CodeStyleHostLanguageServices.cs` (dotnet#60955)
  Allow VSMac to access LSP options (dotnet#60943)
  Add configs for 17.3 branch and update main version (dotnet#60942)
  Restore nugetKind config to publish data
  Remove unnecessary publish data config
  Remove non-servicing 15.x publish config
  Let 'arcade' packageFeeds imply all feeds are 'arcade'
  Remove non-servicing branches from our PublishData
  Handle unexpected keyword rather than identifier for lambda parameter name (dotnet#60825)
  Correctly return E_NOTIMPL when asked for file code models for non-source
  Move the resources to top (dotnet#60899)
  Add back deprecated packages to arcade publishing config.
  Simplify
  Rename parameter
  Simplify visibility logic in tagger
  Simplify visibility logic in tagger
  Try out some fixes
  Update StructConstructorTests.cs
  Use more descriptive variable name
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inheritance margin crashing when multiple symbols are on the same line.

5 participants