Handle unexpected keyword rather than identifier for lambda parameter name#60825
Merged
cston merged 7 commits intodotnet:mainfrom Apr 25, 2022
Merged
Handle unexpected keyword rather than identifier for lambda parameter name#60825cston merged 7 commits intodotnet:mainfrom
cston merged 7 commits intodotnet:mainfrom
Conversation
Youssef1313
reviewed
Apr 19, 2022
| { | ||
| static void Main() | ||
| { | ||
| Action<int> a = int => { }; |
Member
There was a problem hiding this comment.
Consider adding another test for public. Currently the behavior for int (stack exhausting) is different than public (too many syntax errors).
Also consider testing with @int (not too important) #Resolved
Contributor
Author
There was a problem hiding this comment.
Added a parsing test for a full syntax tree with public.
Contributor
Author
|
@dotnet/roslyn-compiler, please review, thanks. |
RikkiGibson
reviewed
Apr 22, 2022
| // x => ... | ||
| // x!! => ... | ||
| var identifier = this.ParseIdentifierToken(); | ||
| var identifier = (this.CurrentToken.Kind != SyntaxKind.IdentifierToken && this.PeekToken(1).Kind == SyntaxKind.EqualsGreaterThanToken) ? |
Member
There was a problem hiding this comment.
Could you clarify why we need to peek for an => here? It seems like we already scanned and determined that this is a lambda? #Resolved
Contributor
Author
There was a problem hiding this comment.
The lambda expression may be x => ... or just => ... (missing parameter name).
Contributor
Author
|
@dotnet/roslyn-compiler, please review, thanks. |
333fred
reviewed
Apr 25, 2022
jcouv
reviewed
Apr 25, 2022
| // x => ... | ||
| // x!! => ... | ||
| var identifier = this.ParseIdentifierToken(); | ||
| var identifier = (this.CurrentToken.Kind != SyntaxKind.IdentifierToken && this.PeekToken(1).Kind == SyntaxKind.EqualsGreaterThanToken) ? |
Member
There was a problem hiding this comment.
Should we also condition on whether there's a !! token?
Never mind, we're removing that feature. #Closed
RikkiGibson
reviewed
Apr 25, 2022
| [Theory] | ||
| public void KeywordParameterName_01(LanguageVersion languageVersion) | ||
| { | ||
| string source = "int =>"; |
Member
There was a problem hiding this comment.
Is this only an issue for non-parenthesized lambdas? What if we had (int, int) =>?
Member
There was a problem hiding this comment.
It might also be good to just test (int) => as well.
333fred
added a commit
that referenced
this pull request
Apr 26, 2022
…ures/semi-auto-props * upstream/main: (266 commits) Pass fallback options (#60803) Rename `CodeStyleHostLanguageServices.cs.cs` to `CodeStyleHostLanguageServices.cs` (#60955) Allow VSMac to access LSP options (#60943) Add configs for 17.3 branch and update main version (#60942) Restore nugetKind config to publish data Remove unnecessary publish data config Remove non-servicing 15.x publish config Let 'arcade' packageFeeds imply all feeds are 'arcade' Remove non-servicing branches from our PublishData Handle unexpected keyword rather than identifier for lambda parameter name (#60825) Correctly return E_NOTIMPL when asked for file code models for non-source Move the resources to top (#60899) Add back deprecated packages to arcade publishing config. Simplify Rename parameter Simplify visibility logic in tagger Simplify visibility logic in tagger Try out some fixes Update StructConstructorTests.cs Use more descriptive variable name ...
333fred
added a commit
that referenced
this pull request
Apr 26, 2022
…ures/required-members * upstream/main: (156 commits) Pass fallback options (#60803) Rename `CodeStyleHostLanguageServices.cs.cs` to `CodeStyleHostLanguageServices.cs` (#60955) Allow VSMac to access LSP options (#60943) Add configs for 17.3 branch and update main version (#60942) Restore nugetKind config to publish data Remove unnecessary publish data config Remove non-servicing 15.x publish config Let 'arcade' packageFeeds imply all feeds are 'arcade' Remove non-servicing branches from our PublishData Handle unexpected keyword rather than identifier for lambda parameter name (#60825) Correctly return E_NOTIMPL when asked for file code models for non-source Move the resources to top (#60899) Add back deprecated packages to arcade publishing config. Simplify Rename parameter Simplify visibility logic in tagger Simplify visibility logic in tagger Try out some fixes Update StructConstructorTests.cs Use more descriptive variable name ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Apr 27, 2022
…o forbid-new * upstream/features/required-members: (156 commits) Pass fallback options (dotnet#60803) Rename `CodeStyleHostLanguageServices.cs.cs` to `CodeStyleHostLanguageServices.cs` (dotnet#60955) Allow VSMac to access LSP options (dotnet#60943) Add configs for 17.3 branch and update main version (dotnet#60942) Restore nugetKind config to publish data Remove unnecessary publish data config Remove non-servicing 15.x publish config Let 'arcade' packageFeeds imply all feeds are 'arcade' Remove non-servicing branches from our PublishData Handle unexpected keyword rather than identifier for lambda parameter name (dotnet#60825) Correctly return E_NOTIMPL when asked for file code models for non-source Move the resources to top (dotnet#60899) Add back deprecated packages to arcade publishing config. Simplify Rename parameter Simplify visibility logic in tagger Simplify visibility logic in tagger Try out some fixes Update StructConstructorTests.cs Use more descriptive variable name ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60661