Optimize InheritanceMarginGlyph construction#56471
Merged
sharwell merged 5 commits intodotnet:mainfrom Sep 20, 2021
Merged
Conversation
Member
|
: ) Actually I am working on a similar change. |
|
|
||
| var cancellationToken = context.UserCancellationToken; | ||
| var rehydrated = await viewModel.DefinitionItem.TryRehydrateAsync(cancellationToken).ConfigureAwait(false); | ||
| if (rehydrated == null) |
Contributor
There was a problem hiding this comment.
aside @Cosifne this is an unfortunate way to do things. it means that navigation could take a large amount of time just to realize the symbol just to get its' location. For source symbols we could greatly speed this up by just store the DocIdSpan and navigating immediately to that.
CyrusNajmabadi
approved these changes
Sep 17, 2021
dbcd5ac to
fe0f68a
Compare
fe0f68a to
db185d3
Compare
sharwell
commented
Sep 20, 2021
...lStudio/Core/Def/Implementation/InheritanceMargin/MarginGlyph/InheritanceMarginGlyph.xaml.cs
Outdated
Show resolved
Hide resolved
Cosifne
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reduces the amount of work required to render Inheritance Margin glyphs which users did not directly interact with.