Skip to content

Merge release/dev17.3 to main-vs-deps#60431

Merged
JoeRobich merged 479 commits intomain-vs-depsfrom
release/dev17.3
Mar 31, 2022
Merged

Merge release/dev17.3 to main-vs-deps#60431
JoeRobich merged 479 commits intomain-vs-depsfrom
release/dev17.3

Conversation

@allisonchou
Copy link
Copy Markdown
Contributor

@allisonchou allisonchou commented Mar 28, 2022

Ideally #60429 should merge before this does.
After this, we should be able to delete release/dev17.3

CyrusNajmabadi and others added 30 commits March 3, 2022 22:51
@CyrusNajmabadi
Merge pull request #59599 from CyrusNajmabadi/firstFix
372547b 
Use the same codepath for computing light-bulb actions to determine if hte lightbulb shoudl appear at all.
@CyrusNajmabadi
Merge pull request #59896 from CyrusNajmabadi/embeddedClassification2
f13576a 
Break out embedded language classification entirely from normal classification
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/release/dev17.3' into asyncNav…
7b656b7 
…igation4
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/release/dev17.3' into embedded…
07e208d 
…Classification3
@CyrusNajmabadi
Merge pull request #59802 from CyrusNajmabadi/asyncNavigation4
fd728d5 
Push the two-step navigation system further through roslyn.
@cston
Additional tests for pattern matching on Span<char> (#59876)
849ec84
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/release/dev17.3' into fixConst…
e621758 
…raints
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/release/dev17.3' into embedded…
e447398 
…Classification3
@cston
Merge remote-tracking branch 'upstream/features/patterns-span-char' i…
6d4b1d5 
…nto merge-patterns-span-char
@cston
Update tests and Language Feature Status
26d8173
@CyrusNajmabadi
Lint
0fc4cad
@CyrusNajmabadi
Lint
60b0f4e
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/release/dev17.3' into asyncNav…
f67d2e5 
…igation5
@CyrusNajmabadi
Merge branch 'asyncNavigation5' into asyncNavigation6
d19b75b
@CyrusNajmabadi
Use proper defaults
53ea709
@CyrusNajmabadi
simplify
674beea
@CyrusNajmabadi
Doc
ac7c231
@CyrusNajmabadi
simplify
5c487f5
@CyrusNajmabadi
Use normal defaults
bbaa00f
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into merges/main-to-rele…
11a10e0 
…ase/dev17.3
@CyrusNajmabadi
Merge branch 'asyncNavigation5' into backgroundWorkIndicator2
a607c1f
@dotnet-bot
Merge pull request #59881 from dotnet/merges/main-to-release/dev17.3
c487908 
Merge main to release/dev17.3
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/release/dev17.3' into backgrou…
d0d084d 
…ndWorkIndicator2
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/release/dev17.3' into fixConst…
ea34e1c 
…raints
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/release/dev17.3' into embedded…
9208002 
…Classification3
@CyrusNajmabadi
Fix lint
0695900
@CyrusNajmabadi
Expose more data in attribute
86a612a
@CyrusNajmabadi
Separate out fallback classifier
cfec500
@CyrusNajmabadi
Merge pull request #59889 from CyrusNajmabadi/fixConstraints
0a1831e 
Add new feature to fix invalid constraints.
@CyrusNajmabadi
Simplify
fbbff78
@allisonchou allisonchou requested review from a team as code owners March 28, 2022 23:24
@allisonchou allisonchou requested a review from a team March 28, 2022 23:24
@allisonchou allisonchou requested a review from a team as a code owner March 28, 2022 23:24
@CyrusNajmabadi
Merge pull request #60426 from CyrusNajmabadi/programMain2
1e7693e 
Port 'Top Level Statements' code style PR to 17.3
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented Mar 29, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 29, 2022

Azure Pipelines successfully started running 4 pipeline(s).

@runfoapp runfoapp bot mentioned this pull request Mar 29, 2022
Closed
@RikkiGibson
Copy link
Copy Markdown
Member

RikkiGibson commented Mar 29, 2022

A VB stack depth test is failing here. Maybe because we recently added a fix to actually run 64-bit tests in 64-bit mode? cc @jaredpar

Expected:
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16),
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16),
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
Actual:
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16),
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
Diff:
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
-->     Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
Expected: True
Actual:   False

I'm assuming the plan is to disable the test and add a tracking issue?

@allisonchou allisonchou mentioned this pull request Mar 30, 2022
Open
@JoeRobich JoeRobich merged commit 3c16fd2 into main-vs-deps Mar 31, 2022
@ghost ghost added this to the Next milestone Mar 31, 2022
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented Mar 31, 2022

Merging as Spanish queue is being fixed in the main to main-vs-deps merge PR.

@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

17.3.P1

Development

Successfully merging this pull request may close these issues.

7 participants

@allisonchou @JoeRobich @RikkiGibson @dibarbet @CyrusNajmabadi @cston @dotnet-bot