Simplify how we handle event change notifications in tagging#60488
Merged
CyrusNajmabadi merged 6 commits intodotnet:release/dev17.3from Mar 31, 2022
Merged
Simplify how we handle event change notifications in tagging#60488CyrusNajmabadi merged 6 commits intodotnet:release/dev17.3from
CyrusNajmabadi merged 6 commits intodotnet:release/dev17.3from
Conversation
CyrusNajmabadi
commented
Mar 30, 2022
| /// </summary> | ||
| private readonly AsyncBatchingWorkQueue<NormalizedSnapshotSpanCollection> _normalPriTagsChangedQueue; | ||
|
|
||
| private readonly ReferenceCountedDisposable<TagSourceState> _tagSourceState = new(new TagSourceState()); |
Contributor
Author
There was a problem hiding this comment.
this basically just needed to wrap a CTS + queue in a threadsafe fashion. However, we can just use a normal AsyncBatchingWorkQueue (already threadsafe) and pull the CTS up to here. we can be threadsafe on the CTS as all the places that use it already have a place they run on the UI thread, so they can be appropriately safe wrt to DIsposal (also on the UI thread).
dibarbet
approved these changes
Mar 31, 2022
allisonchou
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a few changes to simplify things. Instead of manually chaining an unbounded list of Tasks, we instead use a simple async-batching-work-queue. This queue has at most one executing task and one 'queued' task representing hte next piece of work to do.