Merge "list-patterns" feature into main branch#57962
Merged
Conversation
…patterns Merge master to features/list-patterns
…patterns Merge master to features/list-patterns
…tterns Merge main to features/list-patterns
…tterns Merge main to features/list-patterns
…tterns Merge main to features/list-patterns
…tterns Merge main to features/list-patterns
…tterns Merge main to features/list-patterns
…tterns Merge main to features/list-patterns
Refresh `features/list-patterns` with latest bits from `main` branch
# Conflicts: # src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs # src/Compilers/CSharp/Portable/Binder/Binder_Patterns.cs # src/Compilers/CSharp/Portable/Errors/MessageID.cs # src/Compilers/CSharp/Portable/FlowAnalysis/DefiniteAssignment.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_AssignmentOperator.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Call.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_FunctionPointerInvocation.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_IndexerAccess.cs # src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_ObjectOrCollectionInitializerExpression.cs # src/Compilers/CSharp/Portable/PublicAPI.Unshipped.txt # src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf # src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf # src/Compilers/Test/Utilities/CSharp/TestOptions.cs
Merge main into features/list-patterns
…tterns Merge main to features/list-patterns
…ges/main-to-features/list-patterns
…tterns Merge main to features/list-patterns
…tterns Merge main to features/list-patterns
…tterns Merge main to features/list-patterns
…tterns Merge main to features/list-patterns
Merge `main` branch into `list-patterns` branch
Merge `main` branch into `list-patterns`
…tterns Merge main to features/list-patterns
Co-authored-by: AlekseyTs <AlekseyTs@users.noreply.github.com> This changes the bound tree representation of list patterns, slice patterns and implicit indexer accesses to avoid storing property or method symbols. Instead we store BoundIndexerAccess/BoundArrayAccess/BoundCall, which be obtain from existing "Bind*" methods and that we run through `CheckValue`. This ensures that we're not missing on all the validation rules which those include. We intend to do some further refactoring, allowing `CheckValue` to properly deal with placeholders. This will allow us to store the Receiver separately from the IndexerOrSliceAccess and leverage existing placeholder infrastructure.
…tterns Merge main to features/list-patterns
… non-array types. (#57918)
Member
Author
AlekseyTs
approved these changes
Nov 24, 2021
Member
Author
|
The list-patterns feature was merged for VS 17.1p2 and .NET 6.0.200. |
Member
marking my calendar for when Roslyn can adopt the feature :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @AlekseyTs @333fred
Relates to test plan #51289