Skip to content

List patterns: Fix pattern lookup on nullable types#55002

Merged
jcouv merged 4 commits intodotnet:features/list-patternsfrom
alrz:list-patterns-05
Aug 4, 2021
Merged

List patterns: Fix pattern lookup on nullable types#55002
jcouv merged 4 commits intodotnet:features/list-patternsfrom
alrz:list-patterns-05

Conversation

@alrz
Copy link
Copy Markdown
Member

@alrz alrz commented Jul 21, 2021

Test plan #51289

@alrz alrz requested a review from a team as a code owner July 21, 2021 12:55
@ghost ghost added the Area-Compilers label Jul 21, 2021
@alrz alrz requested review from 333fred and jcouv July 21, 2021 12:55
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 2). Only a small test suggestion

@jcouv jcouv self-assigned this Aug 2, 2021
@alrz alrz closed this Aug 2, 2021
@alrz alrz reopened this Aug 2, 2021
@alrz
Copy link
Copy Markdown
Member Author

alrz commented Aug 2, 2021

(CI is not running for some reason)

@333fred
Copy link
Copy Markdown
Member

333fred commented Aug 2, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 4)

@jcouv jcouv merged commit 3e08be9 into dotnet:features/list-patterns Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants