List-patterns: fix build break#56809
Merged
jcouv merged 1 commit intodotnet:features/list-patternsfrom Sep 28, 2021
Merged
Conversation
Member
Author
|
@333fred @dotnet/roslyn-compiler for review. This is not for 17.0, but it's tiny and fixes a build break in the list-pattern feature branch. The break was introduced because we removed this method in the |
333fred
approved these changes
Sep 28, 2021
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 1). @RikkiGibson should probably be the other reviewer.
RikkiGibson
approved these changes
Sep 28, 2021
| return Call(receiverOpt, accessor); | ||
| } | ||
|
|
||
| public BoundExpression Indexer(BoundExpression? receiverOpt, PropertySymbol property, BoundExpression arg0) |
Member
There was a problem hiding this comment.
I had a feeling list-patterns might be using this overload but my "delete unused method" impulse won out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring overload we'd removed in
mainbranchRelates to test plan #51289