Fix crash lowering property pattern where override lacks a get accessor#56586
Merged
RikkiGibson merged 2 commits intodotnet:mainfrom Sep 23, 2021
Merged
Fix crash lowering property pattern where override lacks a get accessor#56586RikkiGibson merged 2 commits intodotnet:mainfrom
RikkiGibson merged 2 commits intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51801.
I added an item to #51289 to ensure we cover an analogous scenario with indexer accesses.
I think this change is analogous to lowering of "conventional" property accesses:
roslyn/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_PropertyAccess.cs
Line 89 in 2eddced