Validate the checksum of source on disk#57541
Merged
davidwengier merged 4 commits intodotnet:mainfrom Nov 5, 2021
Merged
Conversation
tmat
reviewed
Nov 3, 2021
| { | ||
| // TODO: Make sure the hash of the file is correct: https://github.com/dotnet/roslyn/issues/57351 | ||
| return Task.FromResult<TextLoader?>(new FileTextLoader(sourceDocument.FilePath, Encoding.UTF8)); | ||
| using var fileStream = new FileStream(sourceDocument.FilePath, FileMode.Open, FileAccess.Read, FileShare.Read | FileShare.Delete); |
Contributor
There was a problem hiding this comment.
+1, wrap in
tmat
reviewed
Nov 3, 2021
|
|
||
| if (fileChecksum.SequenceEqual(sourceDocument.Checksum)) | ||
| { | ||
| return Task.FromResult<TextLoader?>(new FileTextLoader(sourceDocument.FilePath, Encoding.UTF8)); |
Member
Member
Author
There was a problem hiding this comment.
Yeah, you're right. I was going to leave this for a follow up, as I suspect this API will change when the debugger bits are available, but I should probably just do it now :)
tmat
reviewed
Nov 4, 2021
| if (fileStream is not null) | ||
| { | ||
| // TODO: Don't hard code UTF8: https://github.com/dotnet/roslyn/issues/57350 | ||
| var sourceText = SourceText.From(fileStream, Encoding.UTF8, sourceDocument.HashAlgorithm); |
Member
tmat
approved these changes
Nov 5, 2021
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 8, 2021
…sonly * upstream/main: (829 commits) Re-enable BuildWithCommandLine test (dotnet#57584) Fix expected formatting in tests Simplify PR feedback Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571) Less linq Revert Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb Add test Simplify WIP Install .NET SDK in PR Validation pipeline Revert to VS2019 for PR Validation Update dependencies from https://github.com/dotnet/roslyn build 20211103.8 Validate the checksum of source on disk (dotnet#57541) Clean up VsCodeWindowManager (dotnet#57582) Update VS editor package version Revert to VS2019 for official build Revert to VS2019 for official build StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957) ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 8, 2021
…-struct * upstream/main: (829 commits) Re-enable BuildWithCommandLine test (dotnet#57584) Fix expected formatting in tests Simplify PR feedback Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571) Less linq Revert Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb Add test Simplify WIP Install .NET SDK in PR Validation pipeline Revert to VS2019 for PR Validation Update dependencies from https://github.com/dotnet/roslyn build 20211103.8 Validate the checksum of source on disk (dotnet#57541) Clean up VsCodeWindowManager (dotnet#57582) Update VS editor package version Revert to VS2019 for official build Revert to VS2019 for official build StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57351