Merged
Conversation
JoeRobich
approved these changes
Nov 4, 2021
ryzngard
approved these changes
Nov 4, 2021
jasonmalinowski
approved these changes
Nov 4, 2021
Youssef1313
reviewed
Nov 5, 2021
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 8, 2021
…sonly * upstream/main: (829 commits) Re-enable BuildWithCommandLine test (dotnet#57584) Fix expected formatting in tests Simplify PR feedback Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571) Less linq Revert Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb Add test Simplify WIP Install .NET SDK in PR Validation pipeline Revert to VS2019 for PR Validation Update dependencies from https://github.com/dotnet/roslyn build 20211103.8 Validate the checksum of source on disk (dotnet#57541) Clean up VsCodeWindowManager (dotnet#57582) Update VS editor package version Revert to VS2019 for official build Revert to VS2019 for official build StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957) ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 8, 2021
…-struct * upstream/main: (829 commits) Re-enable BuildWithCommandLine test (dotnet#57584) Fix expected formatting in tests Simplify PR feedback Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571) Less linq Revert Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb Add test Simplify WIP Install .NET SDK in PR Validation pipeline Revert to VS2019 for PR Validation Update dependencies from https://github.com/dotnet/roslyn build 20211103.8 Validate the checksum of source on disk (dotnet#57541) Clean up VsCodeWindowManager (dotnet#57582) Update VS editor package version Revert to VS2019 for official build Revert to VS2019 for official build StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957) ...
allisonchou
added a commit
to allisonchou/roslyn
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was previously disabled for being flaky. This flakiness has been resolved with this PR, which allows us to re-enable the test.
Fixes #18204