Merge FileScopedNamespaces to main#54724
Merged
RikkiGibson merged 25 commits intomainfrom Jul 9, 2021
Merged
Conversation
…copedNamespaces Merge master to features/FileScopedNamespaces
…pedNamespaces Merge main to features/FileScopedNamespaces
…pedNamespaces Merge main to features/FileScopedNamespaces
…pedNamespaces Merge main to features/FileScopedNamespaces
…pedNamespaces Merge main to features/FileScopedNamespaces
…pedNamespaces Merge main to features/FileScopedNamespaces
…pedNamespaces Merge main to features/FileScopedNamespaces
Merge main into FileScopedNamespaces
Co-authored-by: Rikki Gibson <rigibson@microsoft.com>
…lyn into merges/main-to-features/FileScopedNamespaces
…pedNamespaces Merges/main to features/file scoped namespaces
…eatures/FileScopedNamespaces
… into merges/main-to-features/FileScopedNamespaces
… into merges/main-to-features/FileScopedNamespaces
Address FileScopedNamespaces test plan review
jaredpar
approved these changes
Jul 9, 2021
5 tasks
Youssef1313
reviewed
Jul 9, 2021
| public bool IsTopLevelNodeWithMembers([NotNullWhen(true)] SyntaxNode? node) | ||
| { | ||
| return node is NamespaceDeclarationSyntax || | ||
| return node is BaseNamespaceDeclarationSyntax || |
Member
There was a problem hiding this comment.
@CyrusNajmabadi There are other references to NamespaceDeclarationSyntax in this class, some of which I feel they should be adjusted to handle file-scoped namespaces. Are you tracking doing that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan: #49000