Skip to content

Address FileScopedNamespaces test plan review#54669

Merged
RikkiGibson merged 5 commits intodotnet:features/FileScopedNamespacesfrom
RikkiGibson:fsn-tests
Jul 9, 2021
Merged

Address FileScopedNamespaces test plan review#54669
RikkiGibson merged 5 commits intodotnet:features/FileScopedNamespacesfrom
RikkiGibson:fsn-tests

Conversation

@RikkiGibson
Copy link
Member

Test plan: #49000

Addresses some items added during test plan review.

@RikkiGibson RikkiGibson requested review from a team as code owners July 7, 2021 23:36
@ghost ghost added the Area-Compilers label Jul 7, 2021
@RikkiGibson
Copy link
Member Author

@jcouv @chsienki @CyrusNajmabadi for review.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 4)

@jcouv jcouv self-assigned this Jul 9, 2021
@RikkiGibson RikkiGibson merged commit 0c92c3f into dotnet:features/FileScopedNamespaces Jul 9, 2021
@RikkiGibson RikkiGibson deleted the fsn-tests branch July 9, 2021 20:20
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants