Add IDE tests for "file-scoped namespaces"#54374
Merged
RikkiGibson merged 7 commits intodotnet:features/FileScopedNamespacesfrom Jun 25, 2021
Merged
Add IDE tests for "file-scoped namespaces"#54374RikkiGibson merged 7 commits intodotnet:features/FileScopedNamespacesfrom
RikkiGibson merged 7 commits intodotnet:features/FileScopedNamespacesfrom
Conversation
Member
Author
Contributor
Do you have the stack trace available? Could help find a good test for this with more information |
Member
Just a hunch, but a test here for file scoped namespaces might repro it: |
Member
Author
Stack trace |
|
|
||
| class C { }", | ||
| testHost, | ||
| Namespace("NS")); |
Contributor
There was a problem hiding this comment.
would be good to put this (or a copy) in the TotalClassifierTests. Then we can validate that the rest of hte tokens classify properly.
| AssertSmartIndent( | ||
| code, | ||
| indentationLine: 4, | ||
| expectedIndentation: 0); |
Contributor
There was a problem hiding this comment.
can you also add an assert for the lines Above the namespace? and can we have a test that just tests teh behavior of indentation if the semicolon is missing (i'm fine with any behavior, i just want it tested).
| public async Task TestAfterFileScopedNamespace() | ||
| { | ||
| await VerifyKeywordAsync( | ||
| @"namespace NS; $$"); |
Contributor
There was a problem hiding this comment.
ideally a test of namespace keywords that shows it does not appear here. Note: if it does, that's not a big deal, just would be something nice to clean up later.
We should also have tests for using appearing after and before single-line ns.
| case SyntaxKind.NamespaceDeclaration: | ||
| return GetName(((NamespaceDeclarationSyntax)node).Name, options); | ||
| case SyntaxKind.FileScopedNamespaceDeclaration: | ||
| return GetName(((BaseNamespaceDeclarationSyntax)node).Name, options); |
CyrusNajmabadi
approved these changes
Jun 25, 2021
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
LGTM. but see comment about the broken formatting. it's likely a very simple fix somewhere, but it can be annoying to track down where tehse rules get inserted. LMK if you'd like help on that.
Member
Author
I tried reverting the implementation change and adding the test. It doesn't look like it ended up revealing the bad behavior. @davidwengier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan: #49000