Skip to content

File scoped namespaces cleanup#54274

Merged
RikkiGibson merged 2 commits intodotnet:features/FileScopedNamespacesfrom
RikkiGibson:fsn-cleanup
Jun 23, 2021
Merged

File scoped namespaces cleanup#54274
RikkiGibson merged 2 commits intodotnet:features/FileScopedNamespacesfrom
RikkiGibson:fsn-cleanup

Conversation

@RikkiGibson
Copy link
Copy Markdown
Member

@RikkiGibson RikkiGibson commented Jun 21, 2021

Test plan: #49000

Follow up to #48937. This new PR addresses several comment threads from the linked PR, so it may be helpful to have both open when reviewing.

  • 81b66f3 addresses most of the remaining feedback from the PR.
  • de94765 changes several tests to use a Theory to reduce the amount of code needed for the test.

@ghost ghost added the Area-Compilers label Jun 21, 2021
@RikkiGibson RikkiGibson marked this pull request as ready for review June 22, 2021 14:56
@RikkiGibson RikkiGibson requested a review from a team as a code owner June 22, 2021 14:56
@RikkiGibson
Copy link
Copy Markdown
Member Author

@jcouv @chsienki @dotnet/roslyn-compiler Please take a look when you get the chance.

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@RikkiGibson RikkiGibson merged commit 1c60d8c into dotnet:features/FileScopedNamespaces Jun 23, 2021
@jcouv jcouv self-assigned this Jun 23, 2021
@jcouv jcouv added this to the C# 10 milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants