Skip to content

Throw IndexOutOfRangeException from BitVector.this[int] if index < 0#46627

Merged
cston merged 1 commit intodotnet:masterfrom
cston:46621
Aug 7, 2020
Merged

Throw IndexOutOfRangeException from BitVector.this[int] if index < 0#46627
cston merged 1 commit intodotnet:masterfrom
cston:46621

Conversation

@cston
Copy link
Contributor

@cston cston commented Aug 7, 2020

Fixes #46621.

@cston cston requested a review from a team as a code owner August 7, 2020 17:48
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😷

@cston cston requested a review from a team August 7, 2020 21:33
@cston cston merged commit 789a25b into dotnet:master Aug 7, 2020
@ghost ghost added this to the Next milestone Aug 7, 2020
@cston cston deleted the 46621 branch August 7, 2020 22:12
@AlgorithmsAreCool
Copy link

@gafter Just curious, what does the 😷 mean?

333fred added a commit that referenced this pull request Aug 10, 2020
…features/function-pointers

* upstream/master: (465 commits)
  Stop specifying Rich Nav's version of dotnet
  Fix nullable reference warning
  Fix up some calls to SymbolKey.Resolve now that it's annotated
  Remove try/catch of ArgumentException
  Null annotate SymbolKey
  Annotate Location.IsInSource as ensuring SourceTree is non-null
  Fix nullable annotation of Compilation.CreateErrorTypeSymbol
  Update null state for add/remove on field-like events (#46477)
  Throw IndexOutOfRangeException from BitVector.this[int] if index < 0 (#46627)
  Delete some dead support for changing legacy options
  Delete our use of Microsoft.VisualStudio.CodingConventions
  Fix crash in the preview of a code action that modified an .editorconfig
  Move null check above where the variable is used (#46558)
  Add integration test to configure diagnostic severity via editorconfig
  Disable a few Mac tests
  Consider nullability in conversion to constraint type (#46405)
  Added interpolated strings and tests
  Introduce request context (#46557)
  Simplify NativeIntegerAttribute encoding (#46522)
  Update extension getenumerator status. (#46607)
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.CodeAnalysis.BitVector.this[int] should throw IndexOutOfRangeException if index < 0

5 participants