Merged
Conversation
allisonchou
approved these changes
Aug 5, 2020
src/Features/LanguageServer/Protocol/Handler/Definitions/GoToTypeDefinitionHandler.cs
Show resolved
Hide resolved
sharwell
reviewed
Aug 5, 2020
dibarbet
approved these changes
Aug 5, 2020
CyrusNajmabadi
approved these changes
Aug 5, 2020
333fred
added a commit
that referenced
this pull request
Aug 10, 2020
…features/function-pointers * upstream/master: (465 commits) Stop specifying Rich Nav's version of dotnet Fix nullable reference warning Fix up some calls to SymbolKey.Resolve now that it's annotated Remove try/catch of ArgumentException Null annotate SymbolKey Annotate Location.IsInSource as ensuring SourceTree is non-null Fix nullable annotation of Compilation.CreateErrorTypeSymbol Update null state for add/remove on field-like events (#46477) Throw IndexOutOfRangeException from BitVector.this[int] if index < 0 (#46627) Delete some dead support for changing legacy options Delete our use of Microsoft.VisualStudio.CodingConventions Fix crash in the preview of a code action that modified an .editorconfig Move null check above where the variable is used (#46558) Add integration test to configure diagnostic severity via editorconfig Disable a few Mac tests Consider nullability in conversion to constraint type (#46405) Added interpolated strings and tests Introduce request context (#46557) Simplify NativeIntegerAttribute encoding (#46522) Update extension getenumerator status. (#46607) ...
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are already 3 parameters for every LSP request (plus the generic request parameter), and in #46051 I'm planning on adding a couple of new ones, so separating things out to a context object first will make that change easier. I imagine the
RequestContextwill also be a good thing to base some extension methods on to further simplify the handlers in future.I deliberately avoided doing any cleanup to make the review easier.
Merging this in to master so there is less chance of conflicts when things are merged to the feature branch.