Simplify NativeIntegerAttribute encoding#46522
Conversation
|
Is there a corresponding update to design/spec doc? #Resolved |
|
Do we have a write up for what the encoding is here so that others can use it? Similar to what we have for NRT https://github.com/dotnet/roslyn/blob/master/docs/features/nullable-metadata.md #Resolved |
Added docs/features/NativeIntegerAttribute.md to the PR. |
src/Compilers/CSharp/Test/Emit/Attributes/AttributeTests_NativeInteger.cs
Outdated
Show resolved
Hide resolved
|
Done review pass (commit 2). I didn't fully review the tests, as I'm unsure what the IL actually represents. #Closed |
| comp.VerifyDiagnostics(); | ||
|
|
||
| var type = comp.GetTypeByMetadataName("B"); | ||
| Assert.Equal("void B.F0(nint x, nuint y)", type.GetMember("F0").ToDisplayString(FormatWithSpecialTypes)); |
There was a problem hiding this comment.
Consider verifying these on both preview and 8 compilations. #Resolved
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 3). One minor comment about additional testing.
|
@cston is this ready to merge? |
…features/function-pointers * upstream/master: (465 commits) Stop specifying Rich Nav's version of dotnet Fix nullable reference warning Fix up some calls to SymbolKey.Resolve now that it's annotated Remove try/catch of ArgumentException Null annotate SymbolKey Annotate Location.IsInSource as ensuring SourceTree is non-null Fix nullable annotation of Compilation.CreateErrorTypeSymbol Update null state for add/remove on field-like events (#46477) Throw IndexOutOfRangeException from BitVector.this[int] if index < 0 (#46627) Delete some dead support for changing legacy options Delete our use of Microsoft.VisualStudio.CodingConventions Fix crash in the preview of a code action that modified an .editorconfig Move null check above where the variable is used (#46558) Add integration test to configure diagnostic severity via editorconfig Disable a few Mac tests Consider nullability in conversion to constraint type (#46405) Added interpolated strings and tests Introduce request context (#46557) Simplify NativeIntegerAttribute encoding (#46522) Update extension getenumerator status. (#46607) ...
In reply to: 668256851 [](ancestors = 668256851) |
Encode a
boolvalue for eachSystem.IntPtrandSystem.UIntPtronly, and ignore custom modifiers.Fixes #44086.