Skip to content

Merge master to features/target-typing#45856

Merged
143 commits merged intofeatures/target-typingfrom
merges/master-to-features/target-typing
Jul 10, 2020
Merged

Merge master to features/target-typing#45856
143 commits merged intofeatures/target-typingfrom
merges/master-to-features/target-typing

Conversation

@dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into features/target-typing.

git fetch --all
git checkout merges/master-to-features/target-typing
git reset --hard upstream/features/target-typing
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-features/target-typing --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

CyrusNajmabadi and others added 30 commits October 7, 2019 14:24
…c-lambdas

Merge master to features/static-lambdas
…c-lambdas

Merge master to features/static-lambdas
@dotnet-bot dotnet-bot requested review from a team as code owners July 10, 2020 00:03
@dotnet-bot dotnet-bot requested a review from a team July 10, 2020 00:03
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Jul 10, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

RikkiGibson and others added 4 commits July 9, 2020 18:01
…latest design. (#45831)

Related to #45296.

From specification:
If the record is derived from `object`, the record type includes a synthesized readonly property equivalent to a property declared as follows:
```C#
protected Type EqualityContract { get; };
```
The property is `virtual` unless the record type is `sealed`.
The property can be declared explicitly. It is an error if the explicit declaration does not match the expected signature or accessibility, or if the explicit declaration doesn't allow overiding it in a derived type and the record type is not `sealed`.

If the record type is derived from a base record type `Base`, the record type includes a synthesized readonly property equivalent to a property declared as follows:
```C#
protected override Type EqualityContract { get; };
```

The property can be declared explicitly. It is an error if the explicit declaration does not match the expected signature or accessibility, or if the explicit declaration doesn't allow overiding it in a derived type and the record type is not `sealed`. It is an error if either synthesized, or explicitly declared property doesn't override a property with this signature in the record type `Base` (for example, if the property is missing in the `Base`, or sealed, or not virtual, etc.).
The synthesized property returns `typeof(R)` where `R` is the record type.
@gafter gafter removed the Merge Conflicts There are merge conflicts with the base branch. label Jul 10, 2020
@ghost ghost merged commit ba14511 into features/target-typing Jul 10, 2020
@ghost ghost deleted the merges/master-to-features/target-typing branch July 10, 2020 17:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.