Avoid exposing PrimaryWorkspace to LUT/SBD#45766
Merged
tmat merged 2 commits intodotnet:masterfrom Jul 9, 2020
Merged
Conversation
Member
Author
Contributor
|
What is SBD? |
mavasani
reviewed
Jul 8, 2020
...tures/Core/Portable/ExternalAccess/UnitTesting/API/UnitTestingIncrementalAnalyzerProvider.cs
Show resolved
Hide resolved
Member
Author
|
@CyrusNajmabadi SBD = Source Based Discovery (of tests) |
mavasani
approved these changes
Jul 9, 2020
Member
@CyrusNajmabadi It is a service (own by test team) that used to find unit test from the source file without building the project. |
sharwell
approved these changes
Jul 9, 2020
Contributor
sharwell
left a comment
There was a problem hiding this comment.
Looks fine assuming we verified that the partner code is already no longer using the obsolete members that this PR removes.
Member
Author
|
Yes, verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #45730 and #45728