Update static and async keyword recommenders#45812
Merged
RikkiGibson merged 2 commits intodotnet:features/static-lambdasfrom Jul 9, 2020
Merged
Update static and async keyword recommenders#45812RikkiGibson merged 2 commits intodotnet:features/static-lambdasfrom
RikkiGibson merged 2 commits intodotnet:features/static-lambdasfrom
Conversation
src/Features/CSharp/Portable/Completion/KeywordRecommenders/StaticKeywordRecommender.cs
Show resolved
Hide resolved
...haredUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/SyntaxTreeExtensions.cs
Outdated
Show resolved
Hide resolved
| { | ||
| if (token.HasMatchingText(SyntaxKind.AsyncKeyword)) | ||
| { | ||
| // second appearance of "async" not followed by modifier: treat as parameter name |
Contributor
There was a problem hiding this comment.
i really could not care less about thsi case :)
CyrusNajmabadi
approved these changes
Jul 8, 2020
RikkiGibson
commented
Jul 8, 2020
src/Features/CSharp/Portable/Completion/KeywordRecommenders/AsyncKeywordRecommender.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #39606